Skip to content

feat(conversation): add manual MLS migration (WPB-27446) - #5168

Open
MohamadJaara wants to merge 1 commit into
developfrom
mo/WPB-27446-manual-mls-migration
Open

feat(conversation): add manual MLS migration (WPB-27446)#5168
MohamadJaara wants to merge 1 commit into
developfrom
mo/WPB-27446-manual-mls-migration

Conversation

@MohamadJaara

@MohamadJaara MohamadJaara commented Aug 12, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-27446

Goal

Add a temporary manual path for testing Proteus/Mixed conversation migration to MLS during the transition phase.

Jira: WPB-27446

Changes

  • reveal a confirmation dialog after five consecutive taps on the Protocol row
  • allow the action only when MLS migration is enabled, the protocol is Proteus or Mixed, and the conversation team matches the self-user team
  • keep the dialog open on outside taps and show migration loading, success, and failure states
  • invoke the backend migration flow and include backend HTTP code and error label when available
  • add concise lifecycle logs and focused unit coverage

@MohamadJaara
MohamadJaara marked this pull request as ready for review August 12, 2026 10:38
@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.28916% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.52%. Comparing base (27391e0) to head (2565fb2).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...tions/details/GroupConversationDetailsViewModel.kt 71.79% 11 Missing and 11 partials ⚠️
...rc/main/kotlin/com/wire/android/model/Clickable.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (72.28%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5168      +/-   ##
===========================================
+ Coverage    52.46%   52.52%   +0.06%     
===========================================
  Files          740      740              
  Lines        25735    25815      +80     
  Branches      4223     4246      +23     
===========================================
+ Hits         13502    13560      +58     
- Misses       10942    10953      +11     
- Partials      1291     1302      +11     
Files with missing lines Coverage Δ
...ations/details/options/GroupConversationOptions.kt 0.00% <ø> (ø)
...s/details/options/GroupConversationOptionsState.kt 97.36% <100.00%> (+0.22%) ⬆️
...rc/main/kotlin/com/wire/android/model/Clickable.kt 0.00% <0.00%> (ø)
...tions/details/GroupConversationDetailsViewModel.kt 83.09% <71.79%> (-5.96%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27391e0...2565fb2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 638 tests  +9   2 638 ✅ +9   1m 24s ⏱️ -1s
  334 suites ±0       0 💤 ±0 
  334 files   ±0       0 ❌ ±0 

Results for commit 2565fb2. ± Comparison against base commit 27391e0.

♻️ This comment has been updated with latest results.

)
updateState(groupOptionsState.value.copy(isMigratingToMLS = true))
viewModelScope.launch {
when (val result = migrateConversationToMLS(conversationId)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to follow the calls inside the MigrateConversationToMLSUseCase and it seems like not all of the branches with IO operations are executed in IO dispatcher.
I would recommend switching to IO dispatcher in the use case to call it safely from view model (main thread safety).

@MohamadJaara
MohamadJaara force-pushed the mo/WPB-27446-manual-mls-migration branch from dc210c8 to 2565fb2 Compare August 31, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants