feat(conversation): add manual MLS migration (WPB-27446) - #5168
feat(conversation): add manual MLS migration (WPB-27446)#5168MohamadJaara wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (72.28%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5168 +/- ##
===========================================
+ Coverage 52.46% 52.52% +0.06%
===========================================
Files 740 740
Lines 25735 25815 +80
Branches 4223 4246 +23
===========================================
+ Hits 13502 13560 +58
- Misses 10942 10953 +11
- Partials 1291 1302 +11
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
| ) | ||
| updateState(groupOptionsState.value.copy(isMigratingToMLS = true)) | ||
| viewModelScope.launch { | ||
| when (val result = migrateConversationToMLS(conversationId)) { |
There was a problem hiding this comment.
I tried to follow the calls inside the MigrateConversationToMLSUseCase and it seems like not all of the branches with IO operations are executed in IO dispatcher.
I would recommend switching to IO dispatcher in the use case to call it safely from view model (main thread safety).
dc210c8 to
2565fb2
Compare
https://wearezeta.atlassian.net/browse/WPB-27446
Goal
Add a temporary manual path for testing Proteus/Mixed conversation migration to MLS during the transition phase.
Jira: WPB-27446
Changes