Skip to content

feat(crypto): migrate to Core Crypto v10 [WPB-8645] - #5204

Open
MohamadJaara wants to merge 4 commits into
developfrom
mo/test-cc-v10
Open

feat(crypto): migrate to Core Crypto v10 [WPB-8645]#5204
MohamadJaara wants to merge 4 commits into
developfrom
mo/test-cc-v10

Conversation

@MohamadJaara

@MohamadJaara MohamadJaara commented Aug 24, 2026

Copy link
Copy Markdown
Member

@MohamadJaara MohamadJaara changed the title feat(crypto): migrate to Core Crypto v10 feat(crypto): migrate to Core Crypto v10 [WPB-8645] Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 638 tests   2 638 ✅  1m 45s ⏱️
  337 suites      0 💤
  337 files        0 ❌

Results for commit 149930e.

♻️ This comment has been updated with latest results.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara
MohamadJaara requested a review from a team as a code owner August 24, 2026 15:34
@MohamadJaara
MohamadJaara requested review from Garzas and sbakhtiarov and removed request for a team August 24, 2026 15:34
@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

sbakhtiarov
sbakhtiarov previously approved these changes Aug 25, 2026
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.52174% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.65%. Comparing base (969346a) to head (149930e).

Files with missing lines Patch % Lines
...d/ui/e2eiEnrollment/GetE2EICertificateViewModel.kt 59.25% 9 Missing and 2 partials ⚠️
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 0.00% 3 Missing ⚠️
...droid/ui/e2eiEnrollment/E2EIEnrollmentViewModel.kt 0.00% 2 Missing ⚠️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 0.00% 2 Missing ⚠️
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (56.52%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5204      +/-   ##
===========================================
+ Coverage    52.55%   52.65%   +0.10%     
===========================================
  Files          740      741       +1     
  Lines        25745    25749       +4     
  Branches      4224     4220       -4     
===========================================
+ Hits         13530    13559      +29     
+ Misses       10920    10895      -25     
  Partials      1295     1295              
Files with missing lines Coverage Δ
.../android/ui/e2eiEnrollment/GetE2EICertificateUI.kt 100.00% <100.00%> (ø)
...droid/ui/e2eiEnrollment/E2EIEnrollmentViewModel.kt 48.38% <0.00%> (ø)
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 59.44% <0.00%> (ø)
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 68.18% <0.00%> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 56.04% <0.00%> (+1.49%) ⬆️
...d/ui/e2eiEnrollment/GetE2EICertificateViewModel.kt 44.44% <59.25%> (+44.44%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969346a...149930e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@pull-request-size pull-request-size Bot added size/M and removed size/XS labels Sep 1, 2026
@MohamadJaara
MohamadJaara dismissed sbakhtiarov’s stale review September 1, 2026 14:13

need to dismiss this review since the code in kalium changed a bit and need to update the app

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants