Skip to content

feat: delete meeting for me [WPB-27932] - #5236

Open
saleniuk wants to merge 2 commits into
developfrom
feat/meeting-delete-for-me
Open

feat: delete meeting for me [WPB-27932]#5236
saleniuk wants to merge 2 commits into
developfrom
feat/meeting-delete-for-me

Conversation

@saleniuk

@saleniuk saleniuk commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-27932


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Meeting participant who is not a creator, needs to have an option to "delete meeting for me", which basically makes this user to leave the underlying conversation.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

User A creates a meeting and adds user B as a participant, then user B can "delete meeting for me" and it disappears from their meeting list.

Attachments (Optional)

delete.for.me.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 631 tests  +2   2 631 ✅ +2   1m 23s ⏱️ +2s
  334 suites ±0       0 💤 ±0 
  334 files   ±0       0 ❌ ±0 

Results for commit c4f84ac. ± Comparison against base commit 58395b5.

This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both.
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFailure_whenDeletingMeeting_thenFailureMessageIsSentAndDialogIsDismissed()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFutureMeeting_andSelfUserIsMember_whenObserving_thenEditAndDeleteIsNotAvailable()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenPastMeeting_andSelfUserIsMember_whenObserving_thenEditAndDeleteIsNotAvailable()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenSuccess_whenDeletingMeeting_thenSuccessMessageIsSentAndDialogIsDismissed()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFailure_whenDeletingMeetingForEveryone_thenFailureMessageIsSentAndDialogIsDismissed()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFailure_whenDeletingMeetingForMe_thenFailureMessageIsSentAndDialogIsDismissed()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFutureMeeting_andSelfUserIsMember_whenObserving_thenDeleteForMeIsAvailable()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenPastMeeting_andSelfUserIsMember_whenObserving_thenEditIsNotAvailableAndDeleteForMeIsAvailable()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenSuccess_whenDeletingMeetingForEveryone_thenSuccessMessageIsSentAndDialogIsDismissed()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenSuccess_whenDeletingMeetingForMe_thenSuccessMessageIsSentAndDialogIsDismissed()

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.48%. Comparing base (58395b5) to head (c4f84ac).

Files with missing lines Patch % Lines
...meetings/ui/options/MeetingOptionsMenuViewModel.kt 86.36% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5236      +/-   ##
===========================================
+ Coverage    52.46%   52.48%   +0.02%     
===========================================
  Files          740      740              
  Lines        25735    25749      +14     
  Branches      4223     4224       +1     
===========================================
+ Hits         13502    13515      +13     
- Misses       10942    10943       +1     
  Partials      1291     1291              
Files with missing lines Coverage Δ
...feature/meetings/ui/options/DeleteMeetingDialog.kt 100.00% <100.00%> (ø)
...tings/ui/options/MeetingOptionsModalSheetLayout.kt 0.00% <ø> (ø)
...meetings/ui/options/MeetingOptionsMenuViewModel.kt 72.09% <86.36%> (+3.17%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58395b5...c4f84ac. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants