fix(windows): use actual OS build for MSI version check [WPB-5221] - #9730
Merged
screendriver merged 1 commit intoAug 27, 2026
Merged
Conversation
adamlow-wire
marked this pull request as ready for review
August 27, 2026 11:11
adamlow-wire
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
August 27, 2026 11:11
screendriver
approved these changes
Aug 27, 2026
screendriver
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the native MSI rejecting supported Windows 10/11 systems. The correction made during #9722 still trusted Windows Installer's
WindowsBuildproperty, which can report a compatibility value; it rejected Windows 11 Pro 10.0.26200 as unsupported.The launch condition now reads the actual
CurrentBuildNumberfrom the 64-bit Windows registry and requires build 10240 or later.Installed OR ...preserves repair and uninstall, and missing registry data fails closed for a fresh install.Adds a focused regression test and documentation. The Squirrel/EXE path is unchanged.
Validation
wire:protocol registration pass on the affected Windows 11 machineWPB-5221 · Microsoft compatibility-property documentation