Update SharpYaml package to version 2.5.1 - #1504
Conversation
|
@StefH the following change was introduced in the latest Microsoft.OpenApi.YamlReader microsoft/OpenAPI.NET#3027 which added limits MaxAliasExpansionNodeCount. This can be overridden when creating OpenApiYamlReader in the constructor of WireMockOpenApiParser. WireMockOpenApiParserTests.FromText_UsingYaml_ShouldReturnMappings requires increasing the AliasExpansionNodeCount from 5k to over 100k. Should WireMockOpenApiParser take a nullable OpenApiYamlReaderSettings or integer MaxAliasExpansionNodeCount to allow customers to increase this? Or should I revert the PR to just be the SharpYaml version increase? |
|
Yes please keep it to sharpyml. |
|
Why would the AliasExpansionNodeCount be need to increased from 5k to over 100k? 5000 sounds a lot to me ? |
|
It seems 1 million is needed for that example... |
References
Upgrading Microsoft.OpenApi packages to a version which takes SharpYalm 2.1.5 with the following fix xoofx/SharpYaml#130
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java