Skip to content

Update SharpYaml package to version 2.5.1 - #1504

Merged
StefH merged 1 commit into
wiremock:masterfrom
johnthcall:patch-1
Sep 5, 2026
Merged

Update SharpYaml package to version 2.5.1#1504
StefH merged 1 commit into
wiremock:masterfrom
johnthcall:patch-1

Conversation

@johnthcall

@johnthcall johnthcall commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

References

Upgrading Microsoft.OpenApi packages to a version which takes SharpYalm 2.1.5 with the following fix xoofx/SharpYaml#130

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@StefH StefH added the dependencies Pull requests that update a dependency file label Sep 1, 2026
Comment thread src/WireMock.Net.OpenApiParser/WireMock.Net.OpenApiParser.csproj
@johnthcall johnthcall changed the title Update SharpYaml package version to 2.1.5 Update Microsoft.OpenApi packages version to 3.10.2 Sep 1, 2026
@johnthcall

Copy link
Copy Markdown
Contributor Author

@StefH the following change was introduced in the latest Microsoft.OpenApi.YamlReader microsoft/OpenAPI.NET#3027 which added limits MaxAliasExpansionNodeCount. This can be overridden when creating OpenApiYamlReader in the constructor of WireMockOpenApiParser. WireMockOpenApiParserTests.FromText_UsingYaml_ShouldReturnMappings requires increasing the AliasExpansionNodeCount from 5k to over 100k. Should WireMockOpenApiParser take a nullable OpenApiYamlReaderSettings or integer MaxAliasExpansionNodeCount to allow customers to increase this? Or should I revert the PR to just be the SharpYaml version increase?

@StefH

StefH commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Yes please keep it to sharpyml.

@StefH StefH changed the title Update Microsoft.OpenApi packages version to 3.10.2 Update SharpYalm package to version 2.5.1 Sep 5, 2026
@StefH StefH changed the title Update SharpYalm package to version 2.5.1 Update SharpYaml package to version 2.5.1 Sep 5, 2026
@StefH
StefH merged commit 84f4109 into wiremock:master Sep 5, 2026
8 checks passed
@StefH

StefH commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

@johnthcall

Why would the AliasExpansionNodeCount be need to increased from 5k to over 100k?

5000 sounds a lot to me ?

@StefH

StefH commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

It seems 1 million is needed for that example...

@StefH

StefH commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

@StefH

StefH commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

@StefH

StefH commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

#1505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StackOverflowException with deeply nested flow sequences/mappings

2 participants