fix: declare pyproj as a direct dependency#5
Merged
Conversation
chained_eclipse/search.py and chained_eclipse/sensitivity.py both import `pyproj.Geod`, but pyproj was only present transitively via cartopy. Declare it explicitly so the package cannot break if cartopy drops or vendors it. Adds a regression test that imports both modules.
This was referenced Jul 25, 2026
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chained_eclipse/search.pyandchained_eclipse/sensitivity.pyboth dofrom pyproj import Geod, butpyprojwas never listed in[project] dependencies. It only resolved becausecartopypulls it in transitively. If cartopy ever drops or vendors it, both modules break at import time.This declares
pyproj>=3.6explicitly and adds a regression test.pyproject.toml: addpyproj>=3.6to[project] dependenciestests/test_declared_dependencies.py: imports both affected modules, and assertspyprojappears in the declared runtime dependenciesCI runs
uv sync --all-extras --no-editablewithout--frozen, souv.lockis refreshed automatically; a localuv lockbefore merge is still worth running so the lockfile diff lands in this PR rather than drifting.Work plan item P0 / 1.
Scientific impact
Packaging metadata only. No solver, ephemeris, geometry, or output code paths are touched, and
MODEL_VERSIONis unchanged. The 838 km / 3344 kg·m⁻³ second-moon baseline and the 2026-08-12 chained event are unaffected.Checklist
ruff check .passespytestpasses locallyLint/test boxes left unchecked because this branch was pushed without a local run — CI on this PR is the first execution.