fix(Fix_unreachable_netservices_v2): v16 compatibility fixes#5590
fix(Fix_unreachable_netservices_v2): v16 compatibility fixes#5590Joeboyc2 wants to merge 1 commit into
Conversation
Two issues prevent this usermod from building under v16:
1. library.json is missing "build": {"libArchive": false}, causing the
build system to reject it with an error before compilation begins.
2. serializeConfig() no longer has a no-argument overload in v16; the
correct replacement is serializeConfigToFS() which creates the JSON
document internally and writes to the filesystem.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR fixes the FixUnreachableNetServices usermod by ensuring periodic configuration updates are persisted to the filesystem instead of kept in memory. The library manifest is also updated to control build archiving behavior. ChangesFix unreachable netservices v2
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
softhack007
left a comment
There was a problem hiding this comment.
Looks good for me - I don't have any 8266 for testing, however i've checked that serializeConfigToFS() is a proper replacement. In fact, configNeedsWrite = true; would have been sufficient to trigger config writing in the main loop, but it should also work as proposed in this PR.
|
Thanks Frank,
Ive deployed this to 3 of my esp8266s devices and all seems to working well
…On Mon May 11, 2026, 06:03 PM GMT, Frank Möhle ***@***.***> wrote:
@softhack007 approved this pull request.
Looks good for me - I don't have any 8266 for testing, however i've checked that serializeConfigToFS() is a proper replacement. In fact, configNeedsWrite = true; would have been sufficient to trigger config writing in the main loop, but it should also work as proposed in this PR.
—
Reply to this email directly, view it on GitHub <#5590 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6SOLW4CQJUSARXX4PHVAT42IIYTAVCNFSM6AAAAACYX434R2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DENRWGE2TGMRSGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Summary
Two issues prevent
Fix_unreachable_netservices_v2from building under WLED v16:Missing
libArchive: falseinlibrary.json— the v16 build system requires"build": {"libArchive": false}in every usermod'slibrary.json. Without it the build fails immediately withERROR: libArchive=false is missing on usermod(s).serializeConfig()no longer has a no-argument overload — v16 changedserializeConfig()to require aJsonObjectparameter. The correct no-argument replacement for saving config to the filesystem isserializeConfigToFS().Test plan
Fix_unreachable_netservices_v2compiles cleanly in an ESP8266 build environment with both fixes appliedserializeConfigToFS()is the correct equivalent — it allocates the JSON document internally and callsserializeConfig(root)+ writes to LittleFS🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Chores