CSR/CA/X509 refactor and extension support - #285
Draft
aidankeefe2022 wants to merge 1 commit into
Draft
Conversation
Rework the req, x509 and ca commands and their extension handling, and
extend the x509 request test suite to cover them.
- req: rework option parsing and the CSR/self-sign/CA-sign paths, add
-serial and -CAkey
- config: parse subjectAltName, authorityKeyIdentifier,
subjectKeyIdentifier, keyUsage, extendedKeyUsage and
basicConstraints, from both -addext and config sections
wolfCLU_GetOpt is rewritten as a left-to-right argv walk rather than a
scan of the option table, which the reworked x509 parsing depends on.
That is cross-cutting, so the commands taking positional arguments
(enc, dsaparam, dhparam, genkey, rand, sign/verify) are adapted to it
and wolfCLU_checkForArg now takes a struct option. Commands that only
take flags are untouched.
-addext remains single-use, as on main.
fixed issues from skoll review
scope reduction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the req, x509 and ca commands and their extension handling, and extend the x509 request test suite to cover them.
-addext remains single-use, as on main.
fixed issues from skoll review
scope reduction