Hardens terminal background detection#31
Merged
Conversation
- Add TTY guard checking both stdout.isTTY and stdin.isTTY for non-TTY environments - Replace hardcoded 150ms timeout with OSC_TIMEOUT_MS constant (300ms) - Add regex validation for defaultBackground to reject malformed colour formats - Add comprehensive test suite with 19 test cases covering all failure modes Delivers PAP-7045
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the robustness of terminal background mode detection by addressing several edge cases and potential failure points. This change aims to provide more reliable theme detection for the CLI.
stdoutorstdinare not TTYs, ensuring correct behavior in non-interactive contexts like CI/CD pipelines where querying the terminal might lead to hangs or incorrect results.#RRGGBB). Malformed or unsupported color formats (e.g., short hex#RGB, 8-digit hex#RRGGBBAA, orrgb()strings) will now correctly trigger a fallback to 'dark' mode, preventing potential parsing errors.Relates to PAP-7045