add mobench support to ProveKit main#429
Open
dcbuild3r wants to merge 1759 commits into
Open
Conversation
Current WHIR doesn't support out of order NTT.
Update oprf circuits
fix binop bitwidth
fix: binop width selection to preserve byte semantics [LA-D]
fix: bind evals to transcript [LA - K]
…calization-main fix: canonicalize duplicate witness terms in R1CS constraints [LA - C]
fix: bind RSA public exponent to fixed values [LA-E]
…anges Fix : Unbound LogUp Transcript Challenges Let the Prover Choose Lookup Randomness [LA-G]
…erived-indices Fix : Unchecked Witness-Derived Indices Cause Deterministic Prover Panics in RAM and Multiplicity Builders [LA-H]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provespanAndroid mobench fix note
The previous failing run was https://github.com/worldfnd/provekit/actions/runs/26007468825. The missing Vivo Y21 monolithic cell did not recover a BrowserStack session payload or
summary.json; available artifacts only show the BrowserStack fetch timeout after 7200s for buildc943753d95fd0b34f5775aa0a3bc6ff58cbcc3ca. I grepped the recovered Android artifacts and job log forlowmemorykiller,Process * was killed,oom_reaper,SIGKILL, and abnormal signal text; there was no hit because BrowserStack did not return the killed session logs for that cell.Before/failure memory from that run:
What changed:
profile_phase("prove")wraps only the prover entry point. Previouslyprepared.clone()ran insideprofile_phase("prove"), so clone cost and peak memory were charged to proving.failure.jsonnow records attempts, fetch timeout seconds, build id, and any LMK/OOM/SIGKILL lines recovered from attempt/device logs.After numbers: pending the fresh BrowserStack rerun on this commit.
Validation
cargo fmt --allcargo test -p bench-mobile --libcargo test -p bench-mobile --test examples_smokecargo test -p bench-mobile --test passport_smokecargo check -p provekit-ffi --target aarch64-linux-androidwith NDK 26.1aarch64-linux-android34-clangruby -e 'require "yaml"; YAML.load_file(".github/workflows/mobile-bench-reusable.yml")'git diff --check