Rename connector status from "not installed" to "uninstalled" - #27
Conversation
Multi-word `--status` filter values force users to quote the argument (`--status="not installed"`) and break WP-CLI conventions, where flag choices are single tokens. `wp language plugin list` already uses `installed`/`uninstalled`, so follow that precedent. The status value itself is renamed, keeping the filter and the rendered output consistent. Fixes #26 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018gv3vaaHBM91Kv9ijuueSV
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughConnector status terminology changes from ChangesConnector status terminology
Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR consistently renames the connector state from "not installed" to "uninstalled" across behavior, documentation, and examples, with no actionable merge-blocking risk remaining beyond normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
This PR updates the connector status terminology from "not installed" to "uninstalled" for improved clarity and consistency across the codebase.
Key Changes
get_connector_status()method to return'uninstalled'instead of'not installed'Files Modified
src/Connectors_Command.php: Updated status return value, docstrings, and command examplesREADME.md: Updated documentation and command output examplesfeatures/connectors.feature: Updated BDD test scenarios and assertionsThis change improves the user experience by using more concise and conventional terminology for the uninstalled connector state.
https://claude.ai/code/session_018gv3vaaHBM91Kv9ijuueSV
Summary by CodeRabbit
Documentation
Behavior