Skip to content

Rename connector status from "not installed" to "uninstalled" - #27

Merged
swissspidy merged 1 commit into
mainfrom
claude/uninstalled-filter-term-mb50yj
Aug 19, 2026
Merged

Rename connector status from "not installed" to "uninstalled"#27
swissspidy merged 1 commit into
mainfrom
claude/uninstalled-filter-term-mb50yj

Conversation

@swissspidy

@swissspidy swissspidy commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

This PR updates the connector status terminology from "not installed" to "uninstalled" for improved clarity and consistency across the codebase.

Key Changes

  • Updated the get_connector_status() method to return 'uninstalled' instead of 'not installed'
  • Updated documentation in docblocks to reflect the new status value
  • Updated all command examples and test scenarios to use the new terminology
  • Updated the README.md documentation with the new status value and adjusted table formatting for consistency

Files Modified

  • src/Connectors_Command.php: Updated status return value, docstrings, and command examples
  • README.md: Updated documentation and command output examples
  • features/connectors.feature: Updated BDD test scenarios and assertions

This change improves the user experience by using more concise and conventional terminology for the uninstalled connector state.

https://claude.ai/code/session_018gv3vaaHBM91Kv9ijuueSV

Summary by CodeRabbit

  • Documentation

    • Updated connector status terminology from “not installed” to “uninstalled” across command documentation, filter options, and example output.
  • Behavior

    • Connector listing and detail results now use the “uninstalled” status label consistently.
    • Updated filtering expectations and scenarios to reflect the revised terminology.

Multi-word `--status` filter values force users to quote the argument
(`--status="not installed"`) and break WP-CLI conventions, where flag
choices are single tokens. `wp language plugin list` already uses
`installed`/`uninstalled`, so follow that precedent.

The status value itself is renamed, keeping the filter and the rendered
output consistent.

Fixes #26

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018gv3vaaHBM91Kv9ijuueSV
Copilot AI lite review requested due to automatic review settings August 19, 2026 13:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e46b5cbd-8fb7-43cc-a6e0-cbff40f3c66b

📥 Commits

Reviewing files that changed from the base of the PR and between 959765d and 356590b.

📒 Files selected for processing (3)
  • README.md
  • features/connectors.feature
  • src/Connectors_Command.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Connector status terminology changes from not installed to uninstalled in the connector command, README examples, and feature scenarios. The command now returns uninstalled when a connector plugin is absent.

Changes

Connector status terminology

Layer / File(s) Summary
Connector status contract
src/Connectors_Command.php
The command documents and returns uninstalled for connectors without an installed plugin. Its example output uses the new label.
Status documentation and validation
features/connectors.feature, README.md
Feature scenarios, status filters, JSON expectations, and README examples use uninstalled.Estimated code review effort: 1 (Trivial)

Suggested labels: enhancement, command:connectors-get, command:connectors-list

Suggested reviewers: brianhenryie

Merge Risk: ⚪ Minimal · up to 35659

This PR consistently renames the connector state from "not installed" to "uninstalled" across behavior, documentation, and examples, with no actionable merge-blocking risk remaining beyond normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change from "not installed" to "uninstalled" across connector status terminology.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/uninstalled-filter-term-mb50yj

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added command:connectors Related to 'connectors' command scope:documentation Related to documentation scope:testing Related to testing labels Aug 19, 2026
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 1.0.3 milestone Aug 19, 2026
@swissspidy
swissspidy merged commit a1e4195 into main Aug 19, 2026
89 of 90 checks passed
@swissspidy
swissspidy deleted the claude/uninstalled-filter-term-mb50yj branch August 19, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:connectors Related to 'connectors' command scope:documentation Related to documentation scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use not-installed instead of "not installed" for --status filter values

3 participants