Repository navigation
🐛 fix(bones): migrate:to-v3 reads a form tag with PHP inside it - #130
Merged
Merged
Conversation
The Options boilerplate writes action="#<?php echo $mid ?>": the > that closes the PHP ended the tag, so its five POST forms were never listed. The tag is matched over the whole file now, with PHP blocks inside it, and kept when it starts in the markup (a view's HTML, a pages/ class's strings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by running the 3.0 report on the 14 boilerplates: the Options boilerplate writes
<form action="#<?php echo $mid ?>" method="post">, and the>that closes the PHP ended the tag, so its five live POST forms were never listed, while the printed example beside them (rightly) was not either.The tag is now matched over the whole file, PHP blocks inside it included, and kept when it starts in the markup (a view's HTML, a
pages/class's strings). New test:test_a_form_tag_with_php_inside_is_read.composer test: 350 tests and 897 assertions. On a copy of the Options boilerplate the report now listsview.php:137and the five forms ofresource.php(81–96), not the example at 56.Trap met on the way: a PHP close tag inside a
//comment ends the comment and PHP mode; the first version of the explaining comment quoted one, and every console test broke.