Repository navigation
fix: drop graph CSS chunking (chat launcher misplaced) - #77
Merged
Merged
Conversation
cssChunking 'graph' (added in #75 to keep the home's CSS off the docs) orders the chunks by its own cost model, and Mantine's core stylesheet landed after the component modules: every module rule overriding a Mantine component at the same specificity lost. On wpbones.com the chat launcher was position: relative at the foot of the page, 20 px off its left edge, instead of fixed bottom right, and the docs' GitHub buttons had Mantine's border. Measured with getComputedStyle on production and on a local production build without graph (launcher fixed at 1420,880; border back to ours). The price is the home's CSS on the docs again, about 9 KB gzip.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused configuration rollback addresses the documented regression and clearly records its performance tradeoff.
Review effort: Balanced
Findings: None
What changed in this PR
Removes graph CSS chunking to restore correct Mantine component styling in production.
Changes:
- Reverts
cssChunking: 'graph'. - Documents the regression, tradeoff, and future verification requirements.
| File | Description |
|---|---|
next.config.mjs |
Removes unsafe graph CSS chunking. |
CLAUDE.md |
Records the cause, impact, and mitigation guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On wpbones.com the chat launcher only showed at the foot of the page, shifted left, instead of fixed bottom right.
Cause:
cssChunking: 'graph'(added in #75 to keep the home's CSS off the docs) orders the CSS chunks by its own cost model, and Mantine's core stylesheet landed after the component modules. Every module rule overriding a Mantine component at the same specificity lost: the launcher'sposition: fixedbecame Mantine'srelative, and the docs' GitHub buttons got Mantine's border.Measured with
getComputedStyle:relative, at the foot of the page, 20 px off the leftfixed, right edge 1420, bottom 880 at 1440x900Price: the home's CSS is on the docs pages again, about 9 KB gzip (docs LCP ~2.2 s locally instead of ~2.0 s).
CLAUDE.mdrecords the trap and what a layered Mantine would need before trying again.yarn test(65) andyarn buildpass.