ci: pin docs validation to exact published SDK version - #168
Conversation
|
@boalambo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Please let me know if I need to make any adjustments? Thank you @truthixify |
|
CI fails before validation because pnpm pack is being used to download a registry package. It tries to pack the docs project and reports that no package version is defined. Please fetch the exact SDK tarball with npm pack or npm view, then install that file. |
1 similar comment
|
CI fails before validation because pnpm pack is being used to download a registry package. It tries to pack the docs project and reports that no package version is defined. Please fetch the exact SDK tarball with npm pack or npm view, then install that file. |
I will do that now |
You can check for approval now, thank you |
|
The npm pack step works now, but all three jobs stop because package.json pins 1.4.5 while pnpm-lock.yaml still records ^1.4.5. Please regenerate and commit the lockfile, then rerun CI. |
All good, I will fix that soon |
- Add extract-sdk-version job to dynamically read SDK version from package.json - Download published SDK artifact as .tgz before installing - Install packed artifact instead of registry version to ensure exact match - Record tested SDK version in CI output for all validation jobs - Add sdk-version-check workflow to verify version exists on npm before allowing package.json changes - Pin SDK version to exact version (1.4.5) instead of caret range - Add documentation for SDK version update process This ensures docs snippets and tests always validate against the exact published SDK version, preventing issues where local or floating versions differ from published releases.
- Replace pnpm pack with npm pack to download from npm registry - pnpm pack was trying to pack the local docs project instead - npm pack correctly fetches the published package tarball - Update tarball filename to match npm pack output format
- Regenerate pnpm-lock.yaml to reflect exact version 1.4.5 instead of ^1.4.5 - This resolves CI failure where lockfile didn't match package.json
b18a1c7 to
e6977fc
Compare
|
please check now @truthixify |
|
Merged. CI now tests the exact published SDK artifact and the manifest and lockfile agree. Thanks @boalambo. |
|
2 participants
Closes #153
This ensures docs snippets and tests always validate against the exact published SDK version, preventing issues where local or floating versions differ from published releases.