Skip to content

Fix localization qa - #179

Merged
truthixify merged 6 commits into
wraith-protocol:developfrom
Vivian-04:fix-localization-qa
Sep 28, 2026
Merged

truthixify merged 6 commits into
wraith-protocol:developfrom
Vivian-04:fix-localization-qa

Conversation

@Vivian-04

@Vivian-04 Vivian-04 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Closes #162


Fix Localization QA Script and Add CI Workflow

Summary

This PR fixes the existing localization QA logic to properly pair translated documents with their English source pages and wires the checks into CI to enforce structural consistency.

Changes

  • Updated QA Logic: Modifies localization-qa.js to iterate over translated pages instead of blindly treating English navigation pages as translated. It correctly drops the locale suffix to identify the English source (e.g. comparing guides/stellar-quickstart.es against guides/stellar-quickstart).
  • Fails on Drift: The script now checks for structural drift and halts execution via process.exit(1) when mismatches are detected.
  • Fixed JSON Formatting: Addressed a minor formatting error in docs.json that was previously causing the QA script to crash on parsing.
  • GitHub Actions Workflow: Added a new .github/workflows/qa.yml GitHub action that runs on both push and pull_request against the main branch to automatically run the localization QA script.

@github-actions
github-actions Bot changed the base branch from main to develop September 26, 2026 15:50
@github-actions

Copy link
Copy Markdown

Auto-retargeted this PR from main to develop. Wave PRs merge into develop; main is only for release cuts. If you meant to target main deliberately (rare), reply here and we can revert this.

@truthixify

Copy link
Copy Markdown
Contributor

The new QA command crashes before running because localization-qa.js uses require() while this package is ESM. Please convert it to ESM or rename it to .cjs, then make the workflow run that exact command.

@Vivian-04

Copy link
Copy Markdown
Contributor Author

Done.

@truthixify

Copy link
Copy Markdown
Contributor

The script runs now, but it reports Translated pages: 0 and still passes. Add locale metadata to the Spanish quickstart and make missing locale or canonical metadata fail. Please also target develop and remove the unrelated PR description and event schema files.

@truthixify

Copy link
Copy Markdown
Contributor

The requested QA fixes are present, but this branch now conflicts with develop and removes recently added event schema links. Please rebase and preserve the current docs content.

@truthixify
truthixify merged commit f03132b into wraith-protocol:develop Sep 28, 2026
5 checks passed
@truthixify

Copy link
Copy Markdown
Contributor

Merged. Localization QA now pairs translations correctly, enforces metadata, and fails on drift. Thanks @Vivian-04.

This was referenced Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wave 9] Add localization QA for translated documentation

2 participants