Fix localization qa - #179
Conversation
|
Auto-retargeted this PR from |
|
The new QA command crashes before running because localization-qa.js uses require() while this package is ESM. Please convert it to ESM or rename it to .cjs, then make the workflow run that exact command. |
|
Done. |
|
The script runs now, but it reports Translated pages: 0 and still passes. Add locale metadata to the Spanish quickstart and make missing locale or canonical metadata fail. Please also target develop and remove the unrelated PR description and event schema files. |
|
The requested QA fixes are present, but this branch now conflicts with develop and removes recently added event schema links. Please rebase and preserve the current docs content. |
96e7d2c to
e590929
Compare
e590929 to
b0d035f
Compare
|
Merged. Localization QA now pairs translations correctly, enforces metadata, and fails on drift. Thanks @Vivian-04. |
Closes #162
Fix Localization QA Script and Add CI Workflow
Summary
This PR fixes the existing localization QA logic to properly pair translated documents with their English source pages and wires the checks into CI to enforce structural consistency.
Changes
localization-qa.jsto iterate over translated pages instead of blindly treating English navigation pages as translated. It correctly drops the locale suffix to identify the English source (e.g. comparingguides/stellar-quickstart.esagainstguides/stellar-quickstart).process.exit(1)when mismatches are detected.docs.jsonthat was previously causing the QA script to crash on parsing..github/workflows/qa.ymlGitHub action that runs on bothpushandpull_requestagainst themainbranch to automatically run the localization QA script.