Skip to content

buildStealthAnnouncement sends scheme 1, but the v2 announcer requires scheme 2 #231

Description

@Jerryvic911

Found while adding a real funds rescue to the operator recovery drill (wraith-protocol/contracts#199).

On develop, buildStealthAnnouncement in src/chains/stellar/builders.ts calls announce with SCHEME_ID (1). constants.ts also defines SCHEME_ID_V2 = 2, and the v2 announcer contract documents that scheme_id must be 2. The same SCHEME_ID default appears in tx-builder.ts, path-payment.ts, swap.ts and batch.ts.

Expected: announcements built for the v2 announcer use scheme 2, or the builders take a scheme id option.

Workaround: the rescue tool builds the announce call itself with SCHEME_ID_V2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions