Document extract.codes strategy, min/max_length, sort_order, disallow… - #1023
Open
mborodii-prog wants to merge 4 commits into
Open
Document extract.codes strategy, min/max_length, sort_order, disallow…#1023mborodii-prog wants to merge 4 commits into
mborodii-prog wants to merge 4 commits into
Conversation
…ed_patterns, include_multi_part_tokens, and extract_raw params
2 tasks
Collaborator
|
Queue triage (2026-07-27)
Please keep the branch current and put the decision in GitHub. This is one of the five active review slots. |
Contributor
Author
|
@thomasstvr @ebhills documentation is up to date with main branch https://github.com/wrangleworks/Wrangles-Extract-Codes/tree/main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plus the previously undocumented extract_raw, none of which had any docstring coverage in wrangles/extract.py::codes().
'strict'}); only lenient differs by skipping that filter. Default is balanced.
Why
Issue #795 reported that strategy was added to the schema but never fully explained — the docs implied three distinct aggressiveness tiers when the
backend only distinguishes two behaviors. This was verified against the reference implementation (model.py) and reflected accurately in both docstrings.
Changes
extract_raw schema property.
Allow extract.codes tests to pass against both current service behavior and PR #21 behavior
Accept old and new invalid sort_order service error messages