Document pull request workflow and ownership - #1094
Conversation
|
The limit of five is not a GitHub rule. It’s an initial team-wide WIP limit based on your capacity: Five is the midpoint: approximately two PRs per reviewer plus one urgent or overflow slot.
After two weeks, adjust based on evidence: |
There was a problem hiding this comment.
Pull request overview
Adds repository-wide pull request workflow and AI-agent guardrails to make GitHub the single source of truth for PR state/ownership, and to standardize review outputs and PR descriptions for smoother Ukraine/Austin handoffs.
Changes:
- Add
docs/pull-request-workflow.mddefining PR states, ownership, queue limits, and triage routines. - Add
AGENTS.mdrequiring Codex reviews to state a disposition plus 1–3 actor-labeled next steps, and to keep PR descriptions current. - Add a PR template and align
.github/copilot-instructions.mdwith the new workflow/review policy language.
Recommended disposition: Request changes
Next steps
- PR author: Update
docs/pull-request-workflow.mdto avoid hard-codingmilestone:"v1.20"and update.github/pull_request_template.mdto use a repo-relative link that works when rendered in PR bodies. - Reviewer: Verify the updated template link works in an actual PR body preview and that the “Release PRs” search is future-proof, then re-review and approve.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/pull-request-workflow.md | New documented PR state/ownership workflow, queue limits, and triage/search routines. |
| AGENTS.md | New agent rules for dispositions/next-steps blocks and PR-description freshness. |
| .github/pull_request_template.md | New PR template prompting for linkage, validation, risk, and readiness checklist. |
| .github/copilot-instructions.md | Updates/extends Copilot guidance to match the documented workflow and review policy. |
What changed
AGENTS.mdrules requiring explicit review dispositions and one to three actor-labeled next stepsmainas the only integration branch for new work and documents clean recovery of wanted legacydevchangesci,deploy-dev, anddeploy-prod#1115:ci.yml,deploy-dev.yml, andpublish-tagged.ymldevtriggers and mutable-tag behavior as transitional work tracked by Complete and harden the main-based PR, dev deployment, and release lifecycle #1117Why
The code-production bottleneck has moved to review, refinement, conflict resolution, and queue cleanup. The team needs GitHub to show ownership and who acts next across the Ukraine/Austin handoff. The documentation must also reflect the main-based integration decision without pretending that every transitional #1115 workflow behavior has already been removed.
Impact
New work branches from current
mainand targetsmaindirectly. The legacydevbranch is frozen for clean, one-change-at-a-time recovery rather than merged wholesale. Each open PR has one human owner, and owners use GitHub's native Draft, review-request, thread-resolution, and re-review signals to make the handoff explicit.This PR changes documentation, templates, and agent behavior only. It does not modify runtime code or workflow implementation.
Validation
origin/main, including Restructure CI/CD intoci,deploy-dev, anddeploy-prod#1115, without conflictsmainmaincontains only the intended lifecycle documentation, template, agent instructions, and image assetsv1.20saved search with a current-milestone placeholder and update instructiongit diff --checkDocumentation/instruction-only change; no runtime tests were required.