Preserve batched Excel writes across recipe batches - #1112
Merged
Conversation
Handle repeated `excel.sheet.write` batches with changing or reordered columns by aligning rows on column names instead of position. This preserves accumulated Excel output for dynamic dictionary splits and keeps overwrite batches in the original column order, with tests covering both connector-level and recipe batch behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Recipe batches can produce multiple writes to the same Excel sheet. Previously, intermediate recipe batches could be written independently, overwrite mode could discard earlier batches, and changing dictionary keys could shift values into the wrong columns when batches were combined positionally.
Impact
Repeated Excel writes now preserve all accumulated rows. Columns are unioned in first-seen order and row values remain aligned with their column names, including dynamic dictionary outputs.
Validation
9 passedusing pytest 9.0.2SettingWithCopyWarningwarnings and no failuresWorkflow
This PR targets the
devstaging destination for live validation. After staging acceptance, the samerecovery/excel-batch-writesbranch should be proposed separately tomain;devshould not be merged into this branch or intomain.