Skip to content

feat(workshop): model contextual literal semantics - #136

Merged
Teakowa merged 3 commits into
mainfrom
issue-135-contextual-semantics
Aug 31, 2026
Merged

feat(workshop): model contextual literal semantics#136
Teakowa merged 3 commits into
mainfrom
issue-135-contextual-semantics

Conversation

@e54-bot

@e54-bot e54-bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • model contextual literal substitutions as per-parameter catalog metadata
  • normalize accepted source literals into canonical WIR and validate only declared aliases
  • cover Boolean/Number, Null/vector, empty string contexts while preserving comparison polymorphism and the Wait Until numeric exception
  • add executable conformance witnesses and provenance/docs for the reviewed OverPy contract

Validation

  • cargo test --workspace --all-targets --quiet
  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo run --locked -p workshop-rs --bin workshop-catalog-gen -- check
  • git diff --check

Fixes #135

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major — crates/workshop-rs/src/catalog/data/catalog.json (version)

This PR changes canonical catalog semantics and the digest, but leaves the dataset version at 0.1.2. ADR-0001 Decision 5 requires catalog-version to be bumped by any dataset change; otherwise the same catalog version identifies two different semantic datasets. Bump the catalog version and regenerate/update the digest pin.

Minor — crates/workshop-rs/src/catalog/data/catalog.json provenance / docs/provenance.md

The new contextual-semantics evidence points at mutable OverPy master URLs. The existing reference-pinning contract requires version/content-pinned evidence so the audited claim remains attributable later. Point these references at the exact reviewed OverPy pin/commit (or otherwise record the exact audited identity) instead of master.

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Teakowa
Teakowa merged commit 45d01ec into main Aug 31, 2026
4 checks passed
@Teakowa
Teakowa deleted the issue-135-contextual-semantics branch August 31, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit contextual Workshop semantics and strengthen executable conformance

2 participants