Skip to content

feat(wir): preserve player loop target spans - #138

Closed
e54-bot wants to merge 2 commits into
mainfrom
codex/issue-65-player-range-provenance
Closed

feat(wir): preserve player loop target spans#138
e54-bot wants to merge 2 commits into
mainfrom
codex/issue-65-player-range-provenance

Conversation

@e54-bot

@e54-bot e54-bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add target_span to canonical ForPlayerVariable actions
  • populate the exact player-variable identifier span when parsing Workshop
  • keep emission, action width, semantic traversal, and roundtrip equivalence unchanged

Validation

  • cargo fmt --all -- --check
  • cargo test -p workshop-rs --test parser player_variable_loop_preserves_target_span

This is the owning WIR contract required by opy-rs#136. It preserves player binder provenance without adding Workshop semantics.

Carry the exact player-variable identifier span through ForPlayerVariable without changing Workshop emission.
Remove the needless borrow in the player loop target span test.

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as out of scope for workshop-rs. For Player Variable is already a canonical Workshop capability; OPY source/binder provenance belongs in opy-rs and should not require expanding the Workshop WIR contract.

@Teakowa Teakowa closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants