Use semantic dedupe for approved future follow-up filing - #751
Conversation
Bound semantic matching and existing-issue lookup to repository-scoped source context, preserve conservative fallback behavior, and sanitize publication artifacts. Agent-Issue-Provenance: v1 repo=wwind123/coding-review-agent-loop issue=490 flow=approved plan=8a9140f06804e4bf
Issue implementationImplemented the approved semantic follow-up dedupe plan, committed it as ad517fe, pushed the branch, and opened PR #751. Focused tests and all non-containment tests passed; the full suite has two environment-specific inherited-cgroup containment failures. ResultPull request reported: #751. Tests run
-- OpenAI Codex: gpt-5.6-luna (xhigh) |
|
Review verdict: Blocking The two-stage design is sound: deterministic dedupe stays the first pass, the model call is bounded, quota-reset escapes cleanly, replay is checked before any provider/search activity, and only high confidence suppresses. Three problems block merge: the Blocking issues
Same-PR follow-ups
-- Anthropic Claude: claude-opus-5 (medium) |
|
Review verdict: Blocking Blocking review: GitHub PR checks are currently pending ( Blocking issues
Same-PR follow-ups
-- Google Antigravity: Gemini 3.8 Flash (High) |
|
PR review round 1 reconciliation: settled reviewers: Claude, Antigravity. Finalization continues after reconciliation. |
Coder follow-upImplemented and pushed fixes for all Claude and Antigravity review items on the existing PR branch in commit 786a81c. Addressed items
Remaining items
Tests run
-- OpenAI Codex: gpt-5.6-luna (xhigh) |
|
Review verdict: Approved All sixteen carried items are addressed at 786a81c and each has a regression test. Verified directly: the antigravity isolated config now replaces the model chain instead of setting the legacy single-model field, and mkdtemp is cleaned up on the raise path; prompt packing now reserves the instruction/source/proposed prefix first and renders every candidate inside its own budget with a hard assertion instead of a post-render slice (checked the arithmetic for the 50-candidate/12000-char worst case, which now fits); PR-filed bodies render the lookup context; parent issue numbers are excluded from tracker search; usage records are only marked validated after the strict-JSON parse succeeds and are marked invalid_output otherwise; the unreachable int identity branch, the dead creation/summary helpers and their orchestrator imports are gone; reuse-only publications no longer claim issues were filed and the contradictory duplicate Reconciliation line is removed; the inspect-based signature shim is replaced by a real parent_issue_number parameter threaded from cmd_run_pr_round; and README.md now documents the new flags. New tests cover the in-batch group-N merge, the medium-confidence uncertain filing path, the parent-issue exclusion, prompt budgeting, the antigravity config, and invalid-output usage accounting. GitHub checks are still pending ( Prior unresolved item dispositions
-- Anthropic Claude: claude-opus-5 (medium) |
|
Review verdict: Approved All round 1 blocking and same-PR review items (item-1 through item-16) have been resolved with thorough implementation fixes and comprehensive test coverage. GitHub CI checks are currently pending (test check in progress). Prior unresolved item dispositions
-- Google Antigravity: Gemini 3.8 Flash (High) |
|
PR review round 2 reconciliation: settled reviewers: Claude, Antigravity. Finalization continues after reconciliation. |
|
Reviewers approved PR #751; watching GitHub checks in the foreground. No coder or reviewer agents will run while checks remain pending. -- coding-review-agent-loop |
Summary
Verification
systemd-cgroup-v2-inheritedrather than creating the direct scope those tests assert.Fixes #490