Preserve reviewer and coder explanations across review rounds - #759
Open
wwind123 wants to merge 2 commits into
Open
Preserve reviewer and coder explanations across review rounds#759wwind123 wants to merge 2 commits into
wwind123 wants to merge 2 commits into
Conversation
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #757's item-12 loop exposed feedback-delivery gaps in both directions. A reviewer kept an item blocking while putting the remaining implementation defects in its summary, without a disposition note. The coder's next prompt repeated the original item but omitted that latest summary. Conversely, the coder's per-item fix explanations were posted to GitHub but omitted from the next reviewer prompt.
These omissions encouraged partial fixes and repeated arguments. This PR preserves the explanations without deciding the technical merits of item-12 or modifying PR #757. It stays separate from #758's GitHub CI-feedback changes.
Changes
blockingorsame-pr. Reject missing notes and bare status restatements, with guidance to supply the remaining defect, evidence, and required change/test.This reuses existing response fields and saved round metadata; no protocol version, migration, or model call is added. The prompt plumbing changes cover the CLI orchestrator; separate skill-runner context plumbing is not expanded here. Structural validation does not guarantee the semantic quality of an explanation. A new review with genuinely missing rationale can still fail validation and require a reviewer rerun.
Validation
python3 -m pytest tests/ -q --tb=short --maxfail=1: 2,716 passed in 344.33 seconds, at commit8b2bf91. No early stop occurred.git diff --check: passed.An earlier suite run failed one new test because its direct resume fixture used a dictionary instead of the parsed comment object. Two new sanitizer assertions also initially expected preservation within a marker-bearing line, contrary to the existing sanitizer policy. These test fixtures/assertions were corrected; they are included in the final rerun, not treated as pre-existing failures.
A separate
timeout 900 python3 -m pytest tests/ -q --tb=shortinvocation ran in the restricted filesystem sandbox and reported failures includingRead-only file systemwhile creating default subprocess logs under~/.cache/coding-review-agent-loop. That run was interrupted to collect diagnostics and is not counted as a passing suite. The completed ordinary pytest invocation above passed all tests at the same committed head.Regression coverage includes carried blockers/same-PR items, explanation publication/reconciliation, latest coder notes in both reviewer modes and launch modes, metadata-backed resume, stale heads, missing legacy details, initial implementation test caveats, and historical marker neutralization.
Separate Follow-Ups
-- OpenAI Codex