Skip to content

fix: cac by default sets the value to true for --no flags - #2699

Merged
nishu-murmu merged 7 commits into
mainfrom
git-init-cac-issue
Oct 29, 2026
Merged

nishu-murmu merged 7 commits into
mainfrom
git-init-cac-issue

Conversation

@nishu-murmu

Copy link
Copy Markdown
Collaborator

Overview

cac was takes --no flags by default as true, since the flag property was negation by default it was creating confusion.

Manual Testing

  1. cd wxt/packages
  2. run bun wxt init <random package name>
  3. check whether it is asking for git or not?

Related Issue

This PR closes #2697

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f2335355-5fa0-4ad9-9d2e-50713aacf64b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Oct 27, 2026
@netlify

netlify Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 3520644
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6ae2ec1d1703b42b7b086b72
😎 Deploy Preview https://deploy-preview-2699--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@nishu-murmu nishu-murmu changed the title fix: cac by default sets the value to true for --no flags. fix: cac by default sets the value to true for --no flags Oct 27, 2026
@pkg-pr-new

pkg-pr-new Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2699

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2699

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2699

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2699

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2699

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2699

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2699

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2699

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2699

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2699

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2699

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2699

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2699

wxt

npm i https://pkg.pr.new/wxt@2699

commit: 3520644

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

@nishu-murmu You should revert tests also.

@nishu-murmu

Copy link
Copy Markdown
Collaborator Author

@PatrykKuniczak tests fixed! kindly check and let me know!

@fkatsuhiro fkatsuhiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! No concern from my end.

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

@nishu-murmu Still workflow failed.

@nishu-murmu
nishu-murmu merged commit bdfcc52 into main Oct 29, 2026
17 checks passed
@nishu-murmu
nishu-murmu deleted the git-init-cac-issue branch October 29, 2026 06:50
@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.51%. Comparing base (8fb1f6d) to head (3520644).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/wxt/src/initialize.ts 0.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2699      +/-   ##
==========================================
+ Coverage   80.32%   80.51%   +0.19%     
==========================================
  Files         139      139              
  Lines        4162     4162              
  Branches      961      961              
==========================================
+ Hits         3343     3351       +8     
+ Misses        720      714       -6     
+ Partials       99       97       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: During run init command, finish the git initialize process without question to user('Initialize a new git repository?')

4 participants