Repository navigation
fix: cac by default sets the value to true for --no flags - #2699
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
|
@nishu-murmu You should revert tests also. |
… git-init-cac-issue
|
@PatrykKuniczak tests fixed! kindly check and let me know! |
fkatsuhiro
left a comment
There was a problem hiding this comment.
Thanks! No concern from my end.
|
@nishu-murmu Still workflow failed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2699 +/- ##
==========================================
+ Coverage 80.32% 80.51% +0.19%
==========================================
Files 139 139
Lines 4162 4162
Branches 961 961
==========================================
+ Hits 3343 3351 +8
+ Misses 720 714 -6
+ Partials 99 97 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Overview
cacwas takes--noflags by default as true, since the flag property was negation by default it was creating confusion.Manual Testing
wxt/packagesbun wxt init <random package name>Related Issue
This PR closes #2697