Refine notch hover timing and width scaling#208
Open
Lucker-QY wants to merge 5 commits into
Open
Conversation
added 4 commits
June 1, 2026 02:54
… stats, Media controls, Battery, Calendar), and document citations
nguyenvanduocit
pushed a commit
to nguyenvanduocit/CodeIsland
that referenced
this pull request
Jun 2, 2026
…-all (T-062) New items from wxtsky/CodeIsland since May 31: - T-061 (watch): PR wxtsky#208 notch hover 3-state machine + 1% width slider steps - T-062 (investigate): issue wxtsky#212 cmux multi-session expand-all bug - T-021 criteria updated: use 1% slider steps per PR wxtsky#208 pattern - T-057 description updated: note issue wxtsky#210 user scenario - vibeislandapp/vibe-island: no changes (still ba1c889) https://claude.ai/code/session_01HRxeeXu7oCQ73VLVjRnaTz
Owner
|
嗨 @Lucker-QY,非常感谢这个 PR,看得出投入了很多精力 🙏 先说好的部分:hover 三段式状态机( 不过这个 PR 目前没法直接合,主要是范围远超标题描述,里面其实混了三件大事:
另外两个具体问题:
能不能麻烦你拆一下:只把 hover 状态机 + 宽度滑块单独开一个干净的 PR(顺手修掉上面 |
nguyenvanduocit
pushed a commit
to nguyenvanduocit/CodeIsland
that referenced
this pull request
Jun 17, 2026
- No new commits or releases since v1.0.28 (Jun 15); upstream quiet - PR wxtsky#208 declined by upstream maintainer (bundled project rename + WeChat DB access + regression); T-061 gate updated to await a focused hover-timing re-PR instead - Issue wxtsky#227 confirms orphan-permission bug still recurs after v1.0.28 fix; T-065 (.removeSession drain) still needed - PR wxtsky#228 (pi/omp mascot in settings): non-Claude CLI, skipped - vibe-island: no changes since Apr 22 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CVWzZp2ZEQnUhxxWBv8sJt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
The hover behavior now uses a small state machine (
collapsed,prehover,expanded) to separate the immediate visual acknowledgement from the delayed full expansion. This makes accidental cursor passes feel lighter while preserving the existing expanded panel behavior.The collapsed width scale range is centralized in
NotchWidthScale, and the settings slider now uses the shared constants so the UI and width calculation stay aligned.Validation
swift build -c releasepasses.swift test --filter NotchPanelViewTestscould not run in my local environment because this machine only has Command Line Tools selected and SwiftPM fails to importXCTest(no such module 'XCTest').