Conversation
Contributor
❌ Validation failedXBMPet
|
Contributor
|
Already part of #268 |
Author
|
True, excuse me! Fixed it locally, used it, figured I'd PR without checking if anything already existed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7.56 added five uint8 columns to XBMPet at offsets 28-32, which pushed the eleven bools from offsets 28-38 to 33-43 and grew the sheet from 22 to 27 columns. The current definition still describes 22 columns, so the column hash check fails and Lumina.Excel returns null for the sheet.
This adds the five new fields as Unknown12 through Unknown16 between LocationKey and the existing Unknown11 array, following the offset ordering of the sheet. The existing Unknown numbering is left alone.
Verified against game version 2026.09.01.0000.0000: the raw sheet reports 27 columns with the five uint8 at offsets 28-32 and the bools at 33-43, and with the updated definition the sheet loads and rows resolve as expected (row 1 links to Pet 47, Cu Sith).
I left .github/columns.yml untouched since that appears to be updated by the maintainers when new column data is published.