refactor: use new SelectionApi, TrajectoryApi, BusApi - #531
Merged
Merged
Conversation
abc8747
marked this pull request as draft
February 12, 2026 16:30
Owner
|
@abc8747 is this still relevant? |
Contributor
Author
|
Yes, the improved cross-plugin functionality is needed so one plugin can retrieve data from another plugin. I will take a look at cross-plugin again when once open-aviation/tangram#210 is merged |
Owner
|
Ok let's keep this open then! |
…xtlayer - also align the elements to the `route` slot so aircraft and selection layers render above it - this shuold also resolve the runway marker not geographically anchored during pan/zoom
abc8747
force-pushed
the
pr-tangram-0.5.0
branch
from
July 19, 2026 06:49
973dec2 to
67d785a
Compare
also upgrade onnxruntime in uv lock so it supports py314 note that py311 was deprecated in c4e784f but xoolive#535 isn't merged yet
Contributor
Author
|
Should be ready to merge now! I've updated the styles and fixed an issue with the marker not reacting to map movements properly. Also I see that py310 was deprecated in c4e784f, but the ruff and mypy versions of the root repo is still at py310, so I didn't fix it yet (#535 addresses the same issue) The test failures are not related to this PR (timeout on the opensky aircraft metadata csv seems to be a temporary github thing). 
|
abc8747
marked this pull request as ready for review
July 19, 2026 07:17
1 of 2 tasks
skyrock36
pushed a commit
to open-aviation/minisky
that referenced
this pull request
Jul 19, 2026
Match the setup recommended in the tangram plugin guide (https://mode-s.org/tangram/plugins/frontend/) and xoolive/traffic#531: - make example_plugins/tangram_minisky a uv workspace member, so `uv sync --all-packages` installs tangram_core and the plugin (editable) into the repo venv; `uv run tangram serve` / `check-plugin` then work straight from this repository - add tsconfig.vite.json (extends tangram-core's tsconfig.node.json) and the documented @ts-expect-error for the vite-plugin subpath that ships without declarations in tangram_core 0.5.0 - add eslint (typescript-eslint + eslint-plugin-vue) and vue-tsc with lint / typecheck / typecheck:vite / check npm scripts; fix the one real finding (btoa browser global) and the auto-fixable style issues - extend pyright to example_plugins and fix what it found: a dict typing error in tangram.py and Optional-access bugs in example.py - align npm dependency ranges with tangram-core 0.5.0 so `tangram check-plugin` passes - document the dev commands, the workspace run route, and the tangram_exe pattern for running against a local tangram checkout Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
xoolive
pushed a commit
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved inter-plugin communication is now implemented in tangram v0.5, but it still needs some time to mature before a proper release
see: open-aviation/tangram@d4421d0