Skip to content

[feature] issue #20 add min/max_element - #22

Open
ThomasRetornaz wants to merge 4 commits into
xtensor-stack:mainfrom
ThomasRetornaz:tre/feat/minmax
Open

ThomasRetornaz wants to merge 4 commits into
xtensor-stack:mainfrom
ThomasRetornaz:tre/feat/minmax

Conversation

@ThomasRetornaz

Copy link
Copy Markdown
Contributor
  • add code
  • add tests
  • add benchmarks Vs stl

Notes:

  • there is a lot of code duplication beetween min and max implementation, could be factorized but the code will become a bit harder to read. So tell me your preference
  • I try implementing max_value, min_value, its works but the speedup is very tiny vs *max_element, so i remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant