Phase 2C: add controlled local teaching image generation - #28
Merged
Merged
Conversation
xueyang-dev
marked this pull request as ready for review
July 26, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
generation_ready, controlledTeachingImageRequestcompilation/execution, strict PNG verification, complete provenance,VerifiedImageArtifact, and atomic Asset Manifest registration.Final Review Hardening
SaveImageprefix so a prior prompt's cached output cannot be attributed to the current request.Fixed Identities
4fddeb7f9096623f1b77f4708feb96126a08a0cf2,132,696,762bytese9476a13728cd75d8279f6ec8bad753a66a1957ca375a1464dc63b37db6e3916be351ebe7ac01bcdbb018639aadcfd38f136b7dc3f2a3d4d3a24db51d1b210efb86be7b3fc04afc839913e1d7a20aba19d4a0de401beeb08e970c829ef40c658e25c17976054ad0122c943a22631640afd50fa52af960e839ce29cd168c1751eTest Results
npm test— 647 passed, 3 skipped; frontend TypeScript/Vite build and state contracts passednpm run test:e2e— 14 passed834306448582d195bb96f96fa2513b30f560bcf995108b886c687fcc843c6de0img-52f57fda24abf00f3e08b9bb; provenance SHA-25616b13b8924c764850ca62387b922b5cdc94503dc60d166383ccb3438915425f6generation_ready=truewas revalidated before cleanupImpact Checklist
verified_image_artifactremains optional onAssetFile)Notes
pending_review: it is original and text-free, but SD 1.5 did not reliably express the requested wave/greeting, exact person count, or classroom environment. Prompt adherence and classroom-semantic quality remain explicit teacher-review risks.