Remove Kotlin Metadata annotations #129

Activity

1. ctadlock

   changed the title [-]Remove Kotlin Metadata annotation[/-] [+]Remove Kotlin Metadata annotations[/+] on Nov 22, 2022
2. yGuy commented on Nov 22, 2022

   

   yGuy

   on Nov 22, 2022

   Member

   More actions

   IIRC, by default yGuard already removes annotations that are not marked as runtime visible annotations. Can you please provide more information about how these annotations work (are annotated) and how they are used? Because if they don't get removed, then these should be runtime visible annotations which again would indicate that Kotlin might need them at runtime. Pointing to relevant documentation would be helpful to decide on how to proceed. Thanks
3. yGuy

   added

   enhancementNew feature or requestNew feature or request

   needs-informationThere is far too little information available to proceed.There is far too little information available to proceed.

   on Nov 22, 2022
4. Fohlen commented on Mar 18, 2023

   

   Fohlen

   on Mar 18, 2023

   Member

   More actions

   There's a comprehensive blog article from the R8 team here. The Gist is that:

   • removing the annotations breaks Kotlin support
   • the annotation references superclass names (these need to be adjusted)

   To correctly support Kotlin we should therefore adjust superclass references in Kotlin annotations
5. Fohlen

   added

   good first issueGood for newcomersGood for newcomers

   difficulty:mediumSome knowledge required.Some knowledge required.

   and removed

   needs-informationThere is far too little information available to proceed.There is far too little information available to proceed.

   on Mar 18, 2023
6. Fohlen

   removed

   good first issueGood for newcomersGood for newcomers

   on Jan 31, 2024