Upgrade redis to 7.4.9#200
Open
abhiksark wants to merge 2 commits into
Open
Conversation
- test_redis_log_attribute: match the 7.x startup log wording
("Ready to accept connections" replaces "The server is now ready
to accept connections").
- test_slave: redis 7.x enables diskless replication by default, which
delays the initial sync past the old fixed sleep. Set the master's
repl-diskless-sync-delay to 0 and poll for replication instead.
abhiksark
force-pushed
the
upgrade-redis-7.4.9
branch
from
4f449cc to
3490303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Summary
Upgrade the embedded redis-server from 6.2.14 to 7.4.9, the latest 7.x release.
Validation
Built redis 7.4.9 locally and ran the full test suite against it on Python 3.10 (a CI-supported interpreter): all 42 tests pass.
Two tests needed updating for redis 7.x behavior (second commit):
test_redis_log_attribute— the startup log wording changed in 7.x:"Ready to accept connections"replaces"The server is now ready to accept connections".test_slave— redis 7.0 enables diskless replication by default (repl-diskless-sync yes,repl-diskless-sync-delay 5), so the initial sync begins later than the test's fixedsleep(.5)allowed. The test now sets the master'srepl-diskless-sync-delayto0and polls for replication. Replication itself is unaffected.Configuration compatibility
redislite/configuration.pyneeds no changes. The directives renamed in redis 7.x are all still accepted by 7.4.9:slave-serve-stale-data,slave-read-only,slave-priorityremain aliases of theirreplica-*equivalents.hash-max-ziplist-*andzset-max-ziplist-*remain aliases of the*-listpack-*directives.list-max-ziplist-entries/list-max-ziplist-valueare accepted as deprecated directives.slaveofis still an alias ofreplicaof.Changes
setup.py,setup.cfg,screwdriver.yaml,build_scripts/update_redis_server.py— bump redis version to 7.4.9 (mirrors Upgrade redis to 6.2.14 #190).tests/test_client.py,tests/test_slave.py— update for the 7.x log wording and replication defaults described above.Follow-up
Upgrading to redis 8.x will come as a separate PR. Redis 8 bundles additional modules and changed its build system, so it needs build-toolchain verification beyond a version bump.