Repository navigation
fix(sea): always load the VFS polyfill instead of node:vfs - #318
Merged
Merged
Conversation
Core node:vfs ignores the mount prefix and mounts at /dev/null/vfs/<n>, so every /snapshot path fails. Once Node ships vfs unflagged (nodejs/node#66318) every SEA binary would take that path. Refs #317
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #317
prelude/sea-vfs-setup.jstriedrequire('node:vfs')first and fell back to@roberts_lando/vfsonly if that threw. Corenode:vfsignores the mount prefix:Today this only happens with
--experimental-vfs, but nodejs/node#66318 unflags it, so the first Node release that includes it would break every SEA binary built on it.This PR drops the
node:vfsbranch and always loads the polyfill. Making corenode:vfswork (capability check or opt-in) is left for a follow-up.prelude/sea-vfs-setup.js: require@roberts_lando/vfsdirectly.docs/ARCHITECTURE.md: replace the old fallback snippet with why the polyfill is always used.Tested:
yarn build,yarn lint, e2etest-85-sea-enhanced,test-89-sea-fs-ops,test-90-sea-worker-threadson Node 22.