ja: read a leading minus as マイナス - #4
Conversation
A unary + or - was spoken 正の / 負の. Those name a kind of number -- 負の数 is "the negative numbers" as a category -- and are not how -5 is read aloud. Japanese says マイナス 5, with the same word used for the binary operator; the reference's worked example reads -b as マイナス b, and its symbol table gives ± as プラス・オア・マイナス. Three pairs in ClearSpeak_Rules.yaml (the two PosNegSqRoot rules and negative_and_positive) and the prefix forms of "plus" and "minus" in definitions.yaml. Not touched: SharedRules/general.yaml, where 正の / 負の are correct -- there they modify 整数 in "the set of all positive integers".
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesJapanese sign pronunciation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized Japanese speech-output change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
upstream に daisy#722 として提出したのでプリフライトは閉じます。 |
1 participant
Third of the small PRs from daisy#715, independent of daisy#720 and daisy#721.
What is wrong
A unary
+or-was spoken 正の / 負の. Those name a kind of number — 負の数 is "the negative numbers" as a category — and they are not how −5 is read aloud. Japanese reads it マイナス 5, using the same word as the binary operator; there is no separate "negative" word the way English distinguishes "negative five" from "five minus".The reference this series follows agrees: its worked example reads −b as 「マイナス b」, and the symbol table in its appendix gives ± as 「プラス・オア・マイナス」. 負の does not appear anywhere in it.
Changes
Three pairs in
ClearSpeak_Rules.yaml— the twoPosNegSqRootrules andnegative_and_positive— and theprefix=forms ofplusandminusindefinitions.yaml.Deliberately not touched:
SharedRules/general.yaml, where 正の / 負の are correct. There they modify 整数 in "the set of all positive integers", which is exactly the categorical sense that makes them wrong as a reading of −5. A blanket replacement would have broken that, so the patch asserts that file is unchanged.Tests
negative_number(−5 → 「マイナス 5」) in both styles.Related
This is what daisy#721 left out. There, x⁻² came out as 「x の 負の 2 乗」; with this change it reads 「x の マイナス 2 乗」. I did not add that test to either PR because it needs both changes; it belongs in whichever of the two merges second, or in a follow-up.
Also spotted while here, for a later PR rather than this one:
general.yamlrenders ℂ as 「複雑な数字」 ("complicated numbers") and ℕ as 「自然な数字」. The mathematical terms are 複素数 and 自然数.Summary by CodeRabbit
Improvements
Tests