fix(portal): permit whitelisted emails to bypass domain restriction and wire OIDC_ALLOWED_EMAILS in secretEnv - #252
Open
elf-mouse wants to merge 1 commit into
Conversation
…nd wire OIDC_ALLOWED_EMAILS in secretEnv This commit fixes OIDC principal resolution and secret routing for whitelisted emails when an allowed email domain is configured: 1. `plugins/portal/src/oidc.ts`: - Allow explicitly whitelisted emails in `rule.allowedEmails` to pass `resolvePrincipal` without being rejected by `rule.allowedEmailDomain`. 2. `plugins/portal/test/oidc.test.ts`: - Add unit test verifying that explicitly allowed emails bypass domain restriction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes OIDC principal resolution and secret routing for whitelisted emails when an allowed email domain is configured:
plugins/portal/src/oidc.ts:rule.allowedEmailsto passresolvePrincipalwithout being rejected byrule.allowedEmailDomain.plugins/portal/test/oidc.test.ts:Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.