Skip to content

fix(prover): print per-table instruments report on the continuation path #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MauroToscano wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(prover): print per-table instruments report on the continuation path #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions prover/src/continuation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,12 @@ fn prove_epoch(
)
.map_err(|e| Error::Prover(format!("{e:?}")))?;

// Emit this epoch's per-table timing report (same formatter as the monolithic
// path). `start.label` is 1-based (index + 1), so subtract 1 for the 0-based
// epoch number. Gated: zero overhead when the feature is off.
#[cfg(feature = "instruments")]
crate::instruments::print_epoch_report(&format!("EPOCH {}", start.label - 1));

let l2g_root = proof
.proofs
.last()
Expand Down Expand Up @@ -878,7 +884,7 @@ fn prove_global(
pairs.push((air as AirRef, trace, &()));
}

Prover::multi_prove(
let proof = Prover::multi_prove(
pairs,
&mut global_transcript(
elf_bytes,
Expand All @@ -890,7 +896,14 @@ fn prove_global(
#[cfg(feature = "disk-spill")]
stark::storage_mode::StorageMode::Ram,
)
.map_err(|e| Error::Prover(format!("{e:?}")))
.map_err(|e| Error::Prover(format!("{e:?}")))?;

// Cross-epoch global-memory proof: emit its per-table timing report too,
// using the shared monolithic formatter. Gated: zero overhead when off.
#[cfg(feature = "instruments")]
crate::instruments::print_epoch_report("GLOBAL");

Ok(proof)
}

#[allow(clippy::too_many_arguments)]
Expand Down
Loading
Loading