Skip to content

refactor(stark): the grinding factor is not "security_bits" #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MauroToscano merged 1 commit into from
Sep 10, 2026
Merged

refactor(stark): the grinding factor is not "security_bits" #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crypto/stark/src/prover.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2283,11 +2283,11 @@ pub trait IsStarkProver<
// grinding: generate nonce and append it to the transcript
#[cfg(feature = "instruments")]
let t_sub = Instant::now();
let security_bits = air.context().proof_options.grinding_factor;
let grinding_factor = air.context().proof_options.grinding_factor;
let mut nonce = None;
if security_bits > 0 {
if grinding_factor > 0 {
let nonce_value =
grinding::generate_nonce_maybe_gpu(&transcript.state(), security_bits)
grinding::generate_nonce_maybe_gpu(&transcript.state(), grinding_factor)
.expect("nonce not found");
transcript.append_bytes(&nonce_value.to_be_bytes());
nonce = Some(nonce_value);
Expand Down
10 changes: 5 additions & 5 deletions crypto/stark/src/verifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1579,9 +1579,9 @@ pub trait IsStarkVerifier<
}

// Receive grinding value
let security_bits = air.context().proof_options.grinding_factor;
let grinding_factor = air.context().proof_options.grinding_factor;
let mut grinding_seed = [0u8; 32];
if security_bits > 0
if grinding_factor > 0
&& let Some(nonce_value) = proof.nonce()
{
grinding_seed = transcript.state();
Expand Down Expand Up @@ -1662,10 +1662,10 @@ pub trait IsStarkVerifier<
);

// verify grinding
let security_bits = air.context().proof_options.grinding_factor;
if security_bits > 0 {
let grinding_factor = air.context().proof_options.grinding_factor;
if grinding_factor > 0 {
let nonce_is_valid = proof.nonce().is_some_and(|nonce_value| {
grinding::is_valid_nonce(&challenges.grinding_seed, nonce_value, security_bits)
grinding::is_valid_nonce(&challenges.grinding_seed, nonce_value, grinding_factor)
});

if !nonce_is_valid {
Expand Down
Loading