Skip to content

fix(web): keep workspace chooser transition stable - #418

Merged
setkyar merged 1 commit into
mainfrom
fix/workspace-chooser-transition
Oct 7, 2026
Merged

setkyar merged 1 commit into
mainfrom
fix/workspace-chooser-transition

Conversation

@setkyar

@setkyar setkyar commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep the workspace chooser in the main web bundle so in-app navigation does not pause on a lazy-route fallback
  • show a chooser-shaped loading skeleton while auth and workspace membership restore
  • avoid displaying the auth/onboarding loading surface before /workspaces
  • add regression coverage for the workspace chooser loading state

Root cause

ProtectedRoute reused the auth/onboarding loading screen for chooser-mode routes while session state restored. The workspace chooser was also lazy-loaded, adding a second fallback during navigation. Together these made switching workspaces look like a brief return to login.

Validation

  • bun test apps/web/src — 724 passed
  • bunx biome check ...
  • bun run typecheck
  • bun run --filter @wateaminbox/web build
  • git diff --check

Build warnings are limited to the existing lottie-web eval and chunk-size warnings.

@setkyar
setkyar merged commit e073731 into main Oct 7, 2026
9 checks passed
@setkyar
setkyar deleted the fix/workspace-chooser-transition branch October 7, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant