Remove test for schema-wide getter removed in yiisoft/db#1175 - #407
Open
KalimeroMK wants to merge 2 commits into
Open
Remove test for schema-wide getter removed in yiisoft/db#1175#407KalimeroMK wants to merge 2 commits into
KalimeroMK wants to merge 2 commits into
Conversation
yiisoft/db removes getSchemaChecks(), getSchemaDefaultValues(), getSchemaIndexes(), getSchemaPrimaryKeys() and getSchemaUniques() from ConstraintSchemaInterface. The tests covering them here call the removed methods, so they can no longer run. Requires the corresponding yiisoft/db change. Refs yiisoft/db#1175
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
=========================================
Coverage 97.82% 97.82%
Complexity 250 250
=========================================
Files 26 26
Lines 828 828
=========================================
Hits 810 810
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Tigrov
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to yiisoft/db#1175, which removes
getSchemaDefaultValues()fromConstraintSchemaInterface.tests/SchemaTest.php:88delegated toparent::testGetSchemaDefaultValues(), so the call fails withCall to undefined methodonce that method is gone fromCommonSchemaTest. Removing the override;loadTableDefaultValues()still throwsNotSupportedExceptionand is covered throughgetTableDefaultValues().Cannot merge before the core PR. I have no Oracle instance locally, so this one is only verified by isolating the affected test — please let CI confirm.