Repository navigation
chore(yoagent-rutis): cover DSH turn endings - #371
Merged
Merged
Conversation
… tests main (yologdev#372) already dropped the yoke-derive pins, so ci.yml takes main's side and the CI CHANGELOG bullet goes. Doc comments on the five tests, their names in the integration's CLAUDE.md, and the CHANGELOG entry moved under yoagent-rutis Unreleased. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T7iq5hpndSiHQcnAsywKuG
Collaborator
|
Thanks for these tests — they cover every turn ending #363 lists, and the overlap test really pins the owner guard. Reviewed (code + test quality; nothing unsafe, no flakiness found) and adjusted on your branch in 1673edc (a merge commit, so your history is untouched):
Locally: Two optional follow-ups, not blocking: a failed run with no extension named (a provider error, so no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds five integration tests for persisted DSH turn endings and removes obsolete dependency pins from the two MSRV jobs. Closes #363.
Why
The tests read DSH's JSONL events for cancellation, failed runs, overlapping runs, session resets and host shutdown, including a late finish while another run owns the turn.
The
yoke-derive 0.8.2pin conflicts withyoke 0.8.4. The derive crate now declares Rust 1.82, allowing Cargo's resolver to select it.How it was verified
cargo fmt -- --checkcargo clippy --all-targets --all-features(CI runs with-Dwarnings)cargo test --all-featuresOn Linux with Node 22.23.4, core build/rustdoc and bridge fmt, Clippy, tests and rustdoc passed (
--features node,loaderfor the bridge).DSH: 17 passed with
YOAGENT_RUTIS_REQUIRE_RUNTIMES=1, one existing univer smoke ignored. Eight faulty variants fail the new assertions, covering wrong reasons, lost error details, missing end events and removal of the owner guard.Both pin conflicts reproduced on the unchanged base; a derive probe compiled with Rust 1.82. CI passes all 16 jobs on
02370b8, including Rust 1.86/1.88, Linux/macOS/Windows, Wasm, Workers and the Node/Bun/Python/Go fixtures.Checklist
CHANGELOG.mdupdated under## Unreleaseddocs/and/or rustdoc) if user-facing (N/A: tests and CI)