Skip to content

reactify moved from devDeps to deps#9

Open
tajo wants to merge 1 commit into
yuanyan:masterfrom
tajo:missing-reactify
Open

reactify moved from devDeps to deps#9
tajo wants to merge 1 commit into
yuanyan:masterfrom
tajo:missing-reactify

Conversation

@tajo

@tajo tajo commented Apr 15, 2015

Copy link
Copy Markdown

Reactify must be in normal deps, otherwise it doesn't work properly if your project build process is different (for example, I'm using babelify transformation instead of reactify).

Error : Cannot find module 'reactify' from '/Project/node_modules/halogen'

We already discussed that in #1 and you put it back. The other solution is to point package's main to bundled version.

@tajo

tajo commented Apr 16, 2015

Copy link
Copy Markdown
Author

Oh, it was already solved here: #8 and it came back. :-)

@yuanyan

yuanyan commented May 4, 2015

Copy link
Copy Markdown
Owner

@tajo It is javascript source now when you install from npm, still need config reactify to dependencies?

@tajo

tajo commented May 9, 2015

Copy link
Copy Markdown
Author

Yep, I do. The problem is caused by:

  "browserify": {
    "transform": [
      "reactify"
    ]
  },
  "browserify-shim": {
    "react": "global:React"
  },

When I delete it, it works.

@ascrazy

ascrazy commented Jun 30, 2015

Copy link
Copy Markdown

This problem still actual. Maybe it will be better to remove browserify config from package.json and specify transforms in gulpfile directly?

@ascrazy

ascrazy commented Jun 30, 2015

Copy link
Copy Markdown

Oh, I saw that transforms already specified in gulpfile.js, so I believe it is no longer needed in package.json.

@SebT

SebT commented Sep 4, 2015

Copy link
Copy Markdown

+1

@iandoe

iandoe commented Oct 19, 2015

Copy link
Copy Markdown

Hey, i am still getting this error, using react 0.14 and halogen 0.1.10. Any pointers ?

@tajo

tajo commented Oct 19, 2015

Copy link
Copy Markdown
Author

Well, reactify is based on react-tools which were deprecated since June and are completely removed in React 0.14.0. The official JSX transformer is Babel now. So this lib is broken. You can fork it if @yuanyan will not fix it or just copy&paste needed parts (my solution since all I really needed was just one loader).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants