chore(deps): repoint scitex.media at scitex_etc.media (ADR-0001 executed)#317
Open
ywatanabe1989 wants to merge 3 commits into
Open
chore(deps): repoint scitex.media at scitex_etc.media (ADR-0001 executed)#317ywatanabe1989 wants to merge 3 commits into
ywatanabe1989 wants to merge 3 commits into
Conversation
Phase B of the scitex-gen full retirement wave. Operator-confirmed reroute — supersedes ADR-0001 (which had media landing in scitex-etc). Operator's view: media belongs with figure rendering (figrecipe), not with the etc catch-all. Changes: - _DEFAULT_BRANDED["media"]: scitex_etc.media -> figrecipe.media. - _LazyModule for `media` now external="figrecipe.media". - figrecipe pinned to >=0.29.0 at all three sites (top-level core deps, [plt] extra, [dev] group). The new release ships the absorbed figrecipe.media submodule. - scitex-etc==0.2.0 pin kept; scitex-etc develop will retarget 0.2.0 to drop media + wait_key (in a parallel PR) but still ship count_grids/yield_grids/search. - docs/adr/0001-relocate-media-to-scitex-etc.md: status flipped to Superseded with a pointer to this PR. I have read and agree to the SciTeX CLA.
4 tasks
Re-target the media re-export from `figrecipe.media` back to `scitex_etc.media` — ADR-0001 executed (operator decision, 2026-06-07). `scitex.media` is media-reference detection/display for chat-pane / terminal / markdown targets (`render.classify`, `render.detect`, `render.show`, plus a CLI and an MCP server). It is NOT figure-rendering. The previous draft of this PR routed it to **figrecipe** (figure-recipe / scientific plotting), which is the wrong semantic home. That draft is reverted here; figrecipe PR #161 was closed. Changes vs. previous PR draft: - `src/scitex/__init__.py`: `_LazyModule("media", external=...)` flipped from `figrecipe.media` back to `scitex_etc.media`. - `src/scitex/re_export.py`: `_DEFAULT_BRANDED["media"]` flipped from `figrecipe.media` to `scitex_etc.media`. - `pyproject.toml`: drop the `figrecipe>=0.29.0` bumps at the three pin sites (top-level core deps, `[plt]` extra, `[dev]` extra). figrecipe goes back to `>=0.16.0` (the pre-PR pin); the scitex-etc pin moves to `>=0.3.0` at all 3 sites. [etc] extra also drops the `readchar` legacy dep. - `docs/adr/0001-relocate-media-to-scitex-etc.md`: status flipped from "Superseded (figrecipe routing)" to "Executed" — the ADR's original conclusion (scitex-etc) is what shipped. - CHANGELOG: rewritten Unreleased entry to reflect the scitex-etc routing. Companion PRs: - scitex-etc PR #24 — now scoped to drop only wait_key and to keep + promote `scitex_etc.media`; version bump 0.2.0 -> 0.3.0. - figrecipe PR #161 — CLOSED (rejected re-route). I have read and agree to the SciTeX CLA.
ywatanabe1989
changed the title
Per operator: no figrecipe references should remain in committed files after the re-route to scitex-etc lands. Trim the CHANGELOG narrative and the ADR status block to describe the executed scitex-etc decision without naming the rejected alternative. I have read and agree to the SciTeX CLA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repoint
scitex.mediafromfigrecipe.media(the previous PR draft'starget) back to
scitex_etc.media— ADR-0001 executed (operatordecision, 2026-06-07).
scitex.mediais media-reference detection/display for chat-pane /terminal / markdown targets (
render.classify,render.detect,render.show, plus a CLI and an MCP server). It is notfigure-rendering. The previous draft routed it to figrecipe
(figure-recipe / scientific plotting), which is the wrong semantic
home. That draft is reverted in this PR; figrecipe PR #161 is now
closed.
Changes
src/scitex/__init__.py:_LazyModule("media", external=...)flipped from
figrecipe.mediaback toscitex_etc.media.src/scitex/re_export.py:_DEFAULT_BRANDED["media"]flippedfrom
figrecipe.mediatoscitex_etc.media.pyproject.toml:figrecipe>=0.29.0bumps at the three pin sites(top-level core deps,
[plt]extra,[dev]extra). figrecipegoes back to its pre-PR pin
>=0.16.0(it remains a core depvia
figrecipe.diagrametc.).scitex-etcpin moves to>=0.3.0at all 3 sites (top-levelcore deps,
[etc]extra,[all,dev]aggregate).[etc]extra drops the legacyreadchar(it was only used bythe retired
wait_keysurface).docs/adr/0001-relocate-media-to-scitex-etc.md: status flippedfrom "Superseded (figrecipe routing)" to Executed — the ADR's
original conclusion (
scitex-etc) is what shipped.CHANGELOG.md: rewritten Unreleased entry.Merge sequencing
This PR cannot be merged until
scitex-etc 0.3.0is on PyPI(otherwise the
>=0.3.0pin will fail to resolve). Track:Test plan
import scitex; scitex.media.render.classify("x.png")worksend-to-end against
scitex-etc>=0.3.0.I have read and agree to the SciTeX CLA.