ci(quality): scitex-io simple template — audit target = scitex (stop CI flood)#325
Open
ywatanabe1989 wants to merge 1 commit into
Open
ci(quality): scitex-io simple template — audit target = scitex (stop CI flood)#325ywatanabe1989 wants to merge 1 commit into
ywatanabe1989 wants to merge 1 commit into
Conversation
…simple form (stop CI flood) The umbrella's `scitex-quality-audit-on-ubuntu-latest.yml` workflow shallow-cloned the entire ecosystem and ran `scripts/quality/audit_ecosystem.py` — both of which live only in scitex-dev, not in the umbrella source tree. The template was copied from scitex-dev verbatim and was always broken on this repo (the registry-load step fails because `scitex/src/scitex/ecosystem.py` does not exist). Replace with the scitex-io-style simple form: - checkout - setup-python 3.12 - `pip install -e ".[dev]" && pip install "scitex-dev[cli-audit]"` - `scitex-dev ecosystem audit-all scitex --no-version-check` That's exactly the audit that the test suite runs internally via `tests/develop/test_audit.py::test_audit_all_clean`, but standalone so an audit regression is visible even when the matrix is skipped — and it doesn't depend on file-paths inside scitex-dev that have shifted twice (0.11.0 → _ecosystem/_core.py, 0.17.0 → _ecosystem/_registry.py). Library-side fix shipped in scitex-dev 0.17.8. Sibling PRs landing across the consumer fleet with the same broken template. operator-SSoT repo — opening PR, NOT merging.
Draft
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops the daily nightly cron CI-red email from this repo's broken
qualityworkflow.The umbrella's
scitex-quality-audit-on-ubuntu-latest.ymlworkflow body shallow-cloned the entire ecosystem and ranscripts/quality/audit_ecosystem.py— both of which live only in scitex-dev, not in this umbrella source tree. The template was copied from scitex-dev verbatim and was always broken on this repo (the registry-load step fails becausescitex/src/scitex/ecosystem.pydoes not exist).Fix: replace with the scitex-io-style simple form — run
scitex-dev ecosystem audit-all scitex --no-version-check(same audittests/develop/test_audit.py::test_audit_all_cleanruns internally, but standalone). Removes the dependency on scitex-dev's internal layout, which has shifted twice (0.11.0, 0.17.0).Note the audit target is
scitex(the umbrella package), not the repo namescitex-python.Test plan
Notes