feat: add unit tests for model client (_parse_response, MessageBuilder, ModelConfig)#411
Open
nankingjing wants to merge 2 commits into
Open
feat: add unit tests for model client (_parse_response, MessageBuilder, ModelConfig)#411nankingjing wants to merge 2 commits into
nankingjing wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 24 unit tests for the
phone_agent/model/client.pymodule. This is the second pure-logic test suite for the repository (following PR #410 which coveredparse_action).Module tested
phone_agent/model/client.py— the AI model client responsible for parsing raw model output and building OpenAI-format message dictionaries._parse_responseandMessageBuilderare fully deterministic, data-in/data-out functions — no network or device access needed, making them ideal for fast, hermetic unit tests.Test classes (11 classes, 24 test cases)
TestParseResponseFinishfinish(message=...)TestParseResponseDodo(action=...)parsing, incl. finish-takes-precedenceTestParseResponseLegacyXml<think>/<answer>fallback (strip tags)TestParseResponseFallbackTestMessageBuilderSystemcreate_system_messageshapeTestMessageBuilderUsercreate_user_message(text-only + with base64 image)TestMessageBuilderAssistantcreate_assistant_messageshapeTestMessageBuilderRemoveImagesTestMessageBuilderScreenInfobuild_screen_infoJSON (incl. non-ASCII preservation)TestModelConfigDefaultsTestModelResponseDefaultsDesign
tests/test_handler.py): pytest, one test class per rule/method, docstrings.finish>do> XML<answer>> raw fallback).build_screen_infopreserves non-ASCII (Chinese) app names viaensure_ascii=False.