Skip to content

Fix ZFPY contiguous array error when used in Zarr #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tasansal wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −3
Open

Fix ZFPY contiguous array error when used in Zarr #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84e2532
fix contiguous array logic
tasansal Dec 17, 2025
3e4a4c2
lint
tasansal Dec 17, 2025
90b3b1e
update release notes
tasansal Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/release.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ Release notes
Unreleased
----------


Fixes
~~~~~

* Fix Zarr serialization with ZFP when array is a view.
By :user:`Altay Sansal <tasansal>`, :issue:`812`

.. _release_0.16.5:

0.16.5
Expand Down
9 changes: 6 additions & 3 deletions numcodecs/zfpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,16 @@ def encode(self, buf):
"The zfp codec does not support none numpy arrays."
f" Your buffers were {type(buf)}."
)
if buf.flags.c_contiguous:
flatten = False
else:
if buf.flags.f_contiguous:

@d-v-b d-v-b Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't 1D numpy arrays c and f contiguous? and so doesn't this reject 1D arrays?

raise ValueError(
"The zfp codec does not support F order arrays. "
f"Your arrays flags were {buf.flags}."
)
# Force C-contiguous if needed (copies only if not already C-contiguous)
buf = np.ascontiguousarray(buf)

# No flattening needed for C-order
flatten = False
buf = ensure_contiguous_ndarray(buf, flatten=flatten)

# do compression
Expand Down