variants: import Nano 33 BLE Sense updates from 0.55.0#201
Open
soburi wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR imports Arduino Nano 33 BLE Sense (nRF52840) variant updates, expanding the variant’s devicetree configuration and adding variant initialization logic to support board-specific peripherals and sensor power behavior.
Changes:
- Added
initVariant()logic to enable sensor power on startup and a 1200-bps reset hook. - Expanded the variant devicetree overlay with additional digital pins, dual I2C exposure, updated ADC resolution, flash partitions, and peripheral nodes.
- Added per-variant example skip/known-issue metadata files and a variant-specific Kconfig fragment.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| variants/arduino_nano_33_ble_nrf52840_sense/variant.cpp | Adds variant init code for sensor power enable and reset behavior. |
| variants/arduino_nano_33_ble_nrf52840_sense/arduino_nano_33_ble_nrf52840_sense.overlay | Updates devicetree mappings (pins/PWM/ADC/I2C/flash layout) for the Sense variant. |
| variants/arduino_nano_33_ble_nrf52840_sense/arduino_nano_33_ble_nrf52840_sense.conf | Adds variant Kconfig defaults (notably USB/BT/peripheral enables). |
| variants/arduino_nano_33_ble_nrf52840_sense/skip_these_examples.txt | Adds a variant-specific list of examples/libraries to exclude. |
| variants/arduino_nano_33_ble_nrf52840_sense/known_example_issues.txt | Adds a placeholder list for known failing examples for this variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+121
to
+127
| pwms = <&pwm1 1 PWM_HZ(500) PWM_POLARITY_NORMAL>, | ||
| <&pwm1 2 PWM_HZ(500) PWM_POLARITY_NORMAL>, | ||
| <&pwm1 3 PWM_HZ(500) PWM_POLARITY_NORMAL>, | ||
| <&pwm2 0 PWM_HZ(500) PWM_POLARITY_NORMAL>, | ||
| <&pwm2 1 PWM_HZ(500) PWM_POLARITY_NORMAL>, | ||
| <&pwm2 2 PWM_HZ(500) PWM_POLARITY_NORMAL>, | ||
| <&pwm2 3 PWM_HZ(500) PWM_POLARITY_NORMAL>; |
Comment on lines
+18
to
+28
| CONFIG_USB_DEVICE_STACK=y | ||
| CONFIG_USB_DEVICE_PRODUCT="Arduino Nano 33 BLE" | ||
| CONFIG_USB_DEVICE_MANUFACTURER="Arduino" | ||
| CONFIG_USB_DEVICE_VID=0x2341 | ||
| CONFIG_USB_DEVICE_PID=0x035A | ||
|
|
||
| CONFIG_USB_CDC_ACM=y | ||
| CONFIG_USB_CDC_ACM_RINGBUF_SIZE=1024 | ||
| CONFIG_UART_LINE_CTRL=y | ||
| CONFIG_CDC_ACM_DTE_RATE_CALLBACK_SUPPORT=y | ||
|
|
Comment on lines
+17
to
+24
| static const struct gpio_dt_spec enable_sensors = | ||
| GPIO_DT_SPEC_GET(DT_PATH(zephyr_user), pin_enable_gpios); | ||
| if (gpio_is_ready_dt(&enable_sensors)) { | ||
| gpio_flags_t flags = enable_sensors.dt_flags | GPIO_OUTPUT_HIGH | GPIO_ACTIVE_HIGH | NRF_GPIO_DRIVE_H0H1; | ||
| gpio_pin_configure(enable_sensors.port, enable_sensors.pin, flags); | ||
| gpio_pin_set(enable_sensors.port, enable_sensors.pin, HIGH); | ||
| delay(500); | ||
| } |
Bring in the Nano 33 BLE Sense variant changes from the 0.55.0 delta, including board configuration, extended pin mappings, peripheral setup, sensor power initialization, and example skip metadata. USB has not yet been implemented in this repository, cdc_acm_uart is disabled. Co-authored-by: Daniele Cloralio <d.cloralio@arduino.cc> Co-authored-by: Luca Burelli <l.burelli@arduino.cc> Co-authored-by: Martino Facchin <m.facchin@arduino.cc> Co-authored-by: Mike S <CyberMerln@gmail.com> Co-authored-by: bogdanf132 <bogdan_ivanus@yahoo.com> Co-authored-by: pennam <m.pennasilico@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
nano33_ble_sense_update
branch
from
d546a3b to
bdd2943
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring in the Nano 33 BLE Sense variant changes from the 0.55.0 delta, including board configuration, extended pin mappings, peripheral setup, sensor power initialization, and example skip metadata.
USB has not yet been implemented in this repository, cdc_acm_uart is disabled.
This is a temporary measure; additional modifications are required to allow the Nano 33 BLE and Nano 33 BLE Sense to coexist.