Skip to content

Run the signing tool with dnx instead of installing it #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
virzak merged 1 commit into from
Jul 28, 2026
Merged

Run the signing tool with dnx instead of installing it #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,25 +146,22 @@ jobs:
name: packages
path: packages

# Pinned deliberately: the tool that signs the release should not change without
# someone choosing to change it.
- name: Install the signing tool
run: dotnet tool install --global SignUniversal.Cli --version 1.0.32

- name: Sign
env:
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_SIGNER_CLIENT_SECRET }}
AZURE_CLIENT_ID: ${{ secrets.AZURE_SIGNER_CLIENT_ID }}
if: ${{ env.AZURE_CLIENT_SECRET != '' && github.ref == 'refs/heads/master' }}
# dnx runs the tool without installing it. The version stays pinned: the thing
# signing the release should not change without someone choosing to change it.
# --trust-signing-root is required on Linux and its absence is not obvious. Trusted
# Signing issues from Microsoft Identity Verification Root CA 2020, which Linux trust
# stores do not carry, and NuGet refuses to sign against a chain it cannot build:
# without the flag this step fails with only "Certificate chain validation failed".
# The root is installed for this user alone, from the chain the signing service
# itself returned.
run: |
sign-universal sign packages/*.nupkg --trust-signing-root \
dotnet dnx SignUniversal.Cli@1.0.34 --yes sign packages/*.nupkg --trust-signing-root \
--trusted-signing-endpoint "${{ secrets.TRUSTED_SIGNING_ENDPOINT }}" \
--trusted-signing-account "${{ secrets.TRUSTED_SIGNING_ACCOUNT }}" \
--trusted-signing-certificate-profile "${{ secrets.TRUSTED_SIGNING_CERTIFICATE_PROFILE }}"
Expand Down
Loading