Check positional-only argument names#325
Closed
Neroli-realy wants to merge 1 commit into
Closed
Conversation
check_function_argument_names() validated regular, *args, **kwargs and keyword-only parameter names against the leading-underscore rule, but omitted positional-only parameters (those before '/'). A positional-only parameter could therefore be given a protected/injected name and a default value, shadowing an injected guard hook (_getattr_, _getitem_, _write_, _print_) so that generated guard calls resolve to an attacker-controlled local instead of the safe policy hook.
Contributor
Author
|
Closing this. Continuing through coordinated disclosure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argument name validation skips positional-only parameters.
check_function_argument_nameschecks regular args,*args,**kwargs, and keyword-only args for forbidden underscore names, but not positional-only ones (before/).