Skip to content

Remove support for schemas that are loaded from a URL (breaking) - #412

Merged
zFernand0 merged 9 commits into
mainfrom
fix/drop-schema-web-loading
Aug 25, 2026
Merged

Remove support for schemas that are loaded from a URL (breaking)#412
zFernand0 merged 9 commits into
mainfrom
fix/drop-schema-web-loading

Conversation

@ATorrise

@ATorrise ATorrise commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What It Does
Removes support for loading a JSON schema from a remote http(s):// URL via a config file's $schema property.

  • validate_config_json (used during profile loading) now raises a ValueError if $schema is an http(s):// URL, telling the user to use a local file path instead.
  • ConfigFile.schema_list (used by get_env) now returns an empty list and logs/warns instead of making a network request for a remote $schema URL.

Only local schema files (absolute path, relative path, or file://) are supported now.

How to Test
run the new tests and make sure they pass

Review Checklist
I certify that I have:

  • updated the changelog
  • manually tested my changes
  • added/updated automated unit/integration tests
  • created/ran system tests (provide build number if applicable)
  • followed the contribution guidelines

Additional Comments
Breaking! Cases where $schema points at a remote url now fail instead of silently succeeding

Signed-off-by: ATorrise <ambertorrise@gmail.com>
@github-project-automation github-project-automation Bot moved this to New Issues in Zowe CLI Squad Aug 7, 2026
@zowe-robot zowe-robot moved this from New Issues to Review/QA in Zowe CLI Squad Aug 7, 2026
@ATorrise
ATorrise requested review from t1m0thyj and zFernand0 August 7, 2026 19:17
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.49%. Comparing base (0c48fbe) to head (32cf533).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   85.20%   85.49%   +0.28%     
==========================================
  Files          49       49              
  Lines        3002     2993       -9     
==========================================
+ Hits         2558     2559       +1     
+ Misses        444      434      -10     
Flag Coverage Δ
unittests 85.49% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
@ATorrise ATorrise changed the title Removed support for loading JSON schemas from remote URLs Removed support schemas that are loaded from a URL Aug 10, 2026
@ATorrise ATorrise changed the title Removed support schemas that are loaded from a URL Removed support schemas that are loaded from a URL (breaking) Aug 10, 2026
@ATorrise ATorrise changed the title Removed support schemas that are loaded from a URL (breaking) Remove support schemas that are loaded from a URL (breaking) Aug 10, 2026
@ATorrise ATorrise changed the title Remove support schemas that are loaded from a URL (breaking) Remove support for schemas that are loaded from a URL (breaking) Aug 10, 2026

@zFernand0 zFernand0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

I do have one small request about raising the error.
Feel free to get other developer's opinion on this.

Comment thread CHANGELOG.md Outdated
Comment thread src/core/zowe/core_for_zowe_sdk/config_file.py Outdated
Comment thread src/core/zowe/core_for_zowe_sdk/config_file.py Outdated
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 self-assigned this Aug 10, 2026
…into fix/drop-schema-web-loading

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

@zFernand0 zFernand0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0
zFernand0 dismissed their stale review August 24, 2026 20:19

dismiss self-review

@CBforZ

CBforZ commented Aug 24, 2026

Copy link
Copy Markdown

i think this test is still expecting a warning instead of an error:

            with self.assertWarns(UserWarning):
>               result = config_file.schema_list()

tests/unit/core/test_profile_manager.py:307: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

traeok
traeok previously requested changes Aug 25, 2026

@traeok traeok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a desync between the test and latest code changes, plan to approve once resolved 😋

Comment thread tests/unit/core/test_profile_manager.py Outdated
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@zFernand0
zFernand0 dismissed traeok’s stale review August 25, 2026 14:07

test fixed 🙏

@zFernand0
zFernand0 requested a review from traeok August 25, 2026 14:07
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

@traeok traeok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @zFernand0 for the quick resolution 😋

@zFernand0
zFernand0 merged commit 7346994 into main Aug 25, 2026
21 checks passed
@zFernand0
zFernand0 deleted the fix/drop-schema-web-loading branch August 25, 2026 17:27
@github-project-automation github-project-automation Bot moved this from Review/QA to Closed in Zowe CLI Squad Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

5 participants