Remove support for schemas that are loaded from a URL (breaking) - #412
Merged
Conversation
Signed-off-by: ATorrise <ambertorrise@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 85.20% 85.49% +0.28%
==========================================
Files 49 49
Lines 3002 2993 -9
==========================================
+ Hits 2558 2559 +1
+ Misses 444 434 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
zFernand0
previously requested changes
Aug 10, 2026
zFernand0
left a comment
Member
There was a problem hiding this comment.
LGTM! 😋
I do have one small request about raising the error.
Feel free to get other developer's opinion on this.
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
…into fix/drop-schema-web-loading Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
|
i think this test is still expecting a warning instead of an error: |
traeok
previously requested changes
Aug 25, 2026
traeok
left a comment
Member
There was a problem hiding this comment.
Seeing a desync between the test and latest code changes, plan to approve once resolved 😋
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
CBforZ
approved these changes
Aug 25, 2026
traeok
approved these changes
Aug 25, 2026
traeok
left a comment
Member
There was a problem hiding this comment.
LGTM Thanks @zFernand0 for the quick resolution 😋
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does
Removes support for loading a JSON schema from a remote
http(s)://URL via a config file's$schemaproperty.validate_config_json(used during profile loading) now raises aValueErrorif$schemais anhttp(s)://URL, telling the user to use a local file path instead.ConfigFile.schema_list(used byget_env) now returns an empty list and logs/warns instead of making a network request for a remote$schemaURL.Only local schema files (absolute path, relative path, or
file://) are supported now.How to Test
run the new tests and make sure they pass
Review Checklist
I certify that I have:
Additional Comments
Breaking! Cases where
$schemapoints at a remote url now fail instead of silently succeeding