Repository navigation
fix docker build error - #1109
Merged
Merged
Conversation
allyhawkins
previously approved these changes
Oct 2, 2026
allyhawkins
left a comment
allyhawkins
left a comment
Member
There was a problem hiding this comment.
It looks like this didn't solve the problem. I'll approve it but I think it might be due to something else?
one list of links should be enough!
Member
Author
Yes, it was something else: I didn't update the directory to create before making the links. I just updated the link script to automatically make directories (and eliminated the manual directory creation). Don't know why I didn't do that before. Asking for a rereview because the change is now something quite different! |
Member
Author
|
I also added the scripts that run in the docker image as triggers to the workflow to make sure changes don't break unexpectedly again: ace4346 |
allyhawkins
reviewed
Oct 2, 2026
| if [[ -L ${loc} || ! -e ${loc} ]] | ||
| then | ||
| # create parent dirs if they don't exist | ||
| mkdir -p $(dirname ${loc}) |
allyhawkins
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why https://github.com/AlexsLemonade/training-modules/actions/runs/37060621217/job/111016087001 failed, since it was working last week, and nothing significant there seems to have changed, but in case it has something to do with the deprecation warning that appeared, I'm updating modules in this workflow.