Fix build on Windows: parameter shadowed volumeNameLen in cleanGlobPath - #548
Merged
Merged
Conversation
cleanGlobPath's second parameter was named volumeNameLen, shadowing the
module-level volumeNameLen() function. The Windows branch then called it
as a function, but the caller passes a number:
let volumeLen = volumeNameLen(pattern);
;[volumeLen, dir] = cleanGlobPath(dir, volumeLen);
so `node build.mjs` died immediately on Windows with "volumeNameLen is
not a function". The POSIX branch treated the same parameter correctly
as a number, which is why this only ever showed up on Windows.
Renamed the parameter to vollen in both branches and dropped the
redundant call, matching what the caller already computes.
Verified: `npm run build` now completes on Windows and produces the same
three packages it produces on Linux.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 6, 2026
Nawid3333
added a commit
to Nawid3333/FastStream
that referenced
this pull request
Sep 7, 2026
…point Phase 10 is no longer "not started": Andrews54757#548, Andrews54757#549, Andrews54757#550 and Andrews54757#551 are open upstream, with follow-up comments on Andrews54757#547 and Andrews54757#546. The unlisted AMO submission pipeline ran end to end on 2026-09-07 (local sign plus the publish-amo workflow). The baseline re-capture is also recorded as done - the workspace-level baseline now holds the modernised fork at cd728ab (852 files, spot-verified), with the original V1.3.77 upstream build archived separately.
Nawid3333
added a commit
to Nawid3333/FastStream
that referenced
this pull request
Sep 9, 2026
…ributes (Andrews54757#550) Both commits are this fork's own upstream PRs coming back home. Andrews54757#550 (.gitattributes) is a content no-op: the fork's file and Andrew's are byte-identical, since he merged the PR as submitted. Andrews54757#548 lands only the half the fork did not already have. The fork fixed the WIN32 branch of cleanGlobPath in ab0719d (that was the actual Windows build break); upstream's merge also renamed the parameter in the non-WIN32 branch, which is what arrives here. No behaviour change on Windows, and it removes the last divergence from upstream in miniglob.mjs. The fork's removal of the file's blanket /* eslint-disable */ survives the merge -- checked, not assumed. Verified after merging: lint 0, tsc 0, 90 unit tests, all four builds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Nawid3333
added a commit
to Nawid3333/FastStream
that referenced
this pull request
Sep 9, 2026
…mes in the upstream candidates queue A1 (Windows build) and A2 (.gitattributes) merged 2026-09-09 -- mark them `merged` instead of `queued`, since both landed and were pulled back into dev/mv3-modernization by the same day's upstream sync. Add A2b for Andrews54757#549 (drop the unused contextualIdentities permission), which Andrew closed: it is provisioned ahead of an unshipped Firefox API (Bugzilla 1917842), not dead weight. Recorded so nobody re-proposes it on the strength of the same grep that looked convincing the first time. Add `rejected` to the status vocabulary. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node build.mjscurrently fails immediately on Windows:Cause
cleanGlobPath's second parameter is namedvolumeNameLen, which shadows the module-levelvolumeNameLen()function. The Windows branch then tries to call it — but the caller passes a number:The POSIX branch treats that same parameter correctly as a number (
return [volumeNameLen, '.']), which is why this only ever surfaced on Windows.Fix
Renamed the parameter to
vollenin both branches and dropped the redundantvolumeNameLen(path)call, using the value the caller already computed.Test plan
npm run buildcompletes on Windows 11 / Node 26 — previously died before reachingbuild.mjs🤖 Generated with Claude Code